-
Notifications
You must be signed in to change notification settings - Fork 3
[feat] 게임 시작 후 게임 진행 + 타이머 기능 추가 #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 10 commits
aee9991
e9a5a38
0b2689e
de8b3b2
9c4a793
e090bd8
56e0010
a59060d
37c7a65
d8f0d62
f33974b
4031963
65629e2
6444663
d4e8f43
257f09c
d046325
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| package io.f1.backend.domain.game.app; | ||
|
|
||
| import static io.f1.backend.domain.game.mapper.RoomMapper.ofPlayerEvent; | ||
| import static io.f1.backend.domain.game.mapper.RoomMapper.toQuestionResultResponse; | ||
| import static io.f1.backend.domain.game.mapper.RoomMapper.toQuestionStartResponse; | ||
| import static io.f1.backend.domain.game.websocket.WebSocketUtils.getDestination; | ||
|
|
||
| import io.f1.backend.domain.game.dto.MessageType; | ||
| import io.f1.backend.domain.game.dto.RoomEventType; | ||
| import io.f1.backend.domain.game.model.Room; | ||
| import io.f1.backend.domain.game.websocket.MessageSender; | ||
|
|
||
| import lombok.RequiredArgsConstructor; | ||
|
|
||
| import org.springframework.stereotype.Service; | ||
|
|
||
| import java.util.concurrent.ScheduledFuture; | ||
| import java.util.concurrent.TimeUnit; | ||
|
|
||
| @Service | ||
| @RequiredArgsConstructor | ||
| public class TimerService { | ||
|
|
||
| private final MessageSender messageSender; | ||
|
|
||
| private static final String NONE_CORRECT_USER = ""; | ||
| private static final int CONTINUE_DELAY = 3; | ||
|
|
||
| public void startTimer(Room room, int delaySec) { | ||
| cancelTimer(room); | ||
|
|
||
| ScheduledFuture<?> timer = | ||
| room.getScheduler() | ||
| .schedule( | ||
| () -> { | ||
| handleTimeout(room); | ||
| }, | ||
| delaySec + room.getGameSetting().getTimeLimit(), | ||
| TimeUnit.SECONDS); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 오홍.. 재연결 유예시간 로직 구현할 때 참고해서 구현해봐야겠군요 👀 |
||
|
|
||
| room.updateTimer(timer); | ||
| } | ||
|
|
||
| private void handleTimeout(Room room) { | ||
| String destination = getDestination(room.getId()); | ||
|
|
||
| messageSender.send( | ||
| destination, | ||
| MessageType.QUESTION_RESULT, | ||
| toQuestionResultResponse(NONE_CORRECT_USER, room.getCurrentQuestion().getAnswer())); | ||
| messageSender.send( | ||
| destination, | ||
| MessageType.SYSTEM_NOTICE, | ||
| ofPlayerEvent(NONE_CORRECT_USER, RoomEventType.TIMEOUT)); | ||
|
|
||
| // TODO : 게임 종료 로직 | ||
| if (!validateCurrentRound(room)) { | ||
| // 게임 종료 로직 | ||
| // GAME_SETTING, PLAYER_LIST, GAME_RESULT, ROOM_SETTING | ||
| return; | ||
| } | ||
|
|
||
| // 다음 문제 출제 | ||
| room.increaseCurrentRound(); | ||
|
|
||
| startTimer(room, CONTINUE_DELAY); | ||
| messageSender.send( | ||
| destination, | ||
| MessageType.QUESTION_START, | ||
| toQuestionStartResponse(room, CONTINUE_DELAY)); | ||
| } | ||
|
|
||
| public boolean validateCurrentRound(Room room) { | ||
| if (room.getGameSetting().getRound() != room.getCurrentRound()) { | ||
| return true; | ||
| } | ||
| cancelTimer(room); | ||
| room.getScheduler().shutdown(); | ||
| return false; | ||
| } | ||
|
|
||
| public void cancelTimer(Room room) { | ||
| // 정답 맞혔어요 ~ 타이머 캔슬 부탁 | ||
| ScheduledFuture<?> timer = room.getTimer(); | ||
| if (timer != null && !timer.isDone()) { | ||
| timer.cancel(false); | ||
| } | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| package io.f1.backend.domain.game.dto; | ||
|
|
||
| public enum GameEventType { | ||
| START, | ||
| CONTINUE | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,4 +9,5 @@ public enum MessageType { | |
| CHAT, | ||
| QUESTION_RESULT, | ||
| RANK_UPDATE, | ||
| QUESTION_START | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,4 +5,6 @@ public enum RoomEventType { | |
| EXIT, | ||
| START, | ||
| END, | ||
| CORRECT_ANSWER, | ||
| TIMEOUT | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| package io.f1.backend.domain.game.dto.response; | ||
|
|
||
| public record QuestionResultResponse(Long questionId, String correctUser, String answer) {} | ||
| public record QuestionResultResponse(String correctUser, String answer) {} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| package io.f1.backend.domain.game.dto.response; | ||
|
|
||
| import java.time.Instant; | ||
|
|
||
| public record QuestionStartResponse(Long questionId, int round, Instant timestamp) {} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| package io.f1.backend.domain.game.mapper; | ||
|
|
||
| import io.f1.backend.domain.game.dto.ChatMessage; | ||
| import io.f1.backend.domain.game.dto.Rank; | ||
| import io.f1.backend.domain.game.dto.RoomEventType; | ||
| import io.f1.backend.domain.game.dto.request.RoomCreateRequest; | ||
| import io.f1.backend.domain.game.dto.response.GameSettingResponse; | ||
| import io.f1.backend.domain.game.dto.response.PlayerListResponse; | ||
| import io.f1.backend.domain.game.dto.response.PlayerResponse; | ||
| import io.f1.backend.domain.game.dto.response.QuestionResultResponse; | ||
| import io.f1.backend.domain.game.dto.response.QuestionStartResponse; | ||
| import io.f1.backend.domain.game.dto.response.QuizResponse; | ||
| import io.f1.backend.domain.game.dto.response.RankUpdateResponse; | ||
| import io.f1.backend.domain.game.dto.response.RoomResponse; | ||
|
|
@@ -91,13 +91,17 @@ public static SystemNoticeResponse ofPlayerEvent(String nickname, RoomEventType | |
| message = " 님이 입장하셨습니다"; | ||
| } else if (roomEventType == RoomEventType.EXIT) { | ||
| message = " 님이 퇴장하셨습니다"; | ||
| } else if (roomEventType == RoomEventType.CORRECT_ANSWER) { | ||
| message = " 님 정답입니다 !"; | ||
| } else if (roomEventType == RoomEventType.TIMEOUT) { | ||
| message = "땡 ~ ⏰ 제한 시간 초과!"; | ||
|
||
| } | ||
| return new SystemNoticeResponse(nickname + message, Instant.now()); | ||
| } | ||
|
|
||
| public static QuestionResultResponse toQuestionResultResponse( | ||
| Long questionId, ChatMessage chatMessage, String answer) { | ||
| return new QuestionResultResponse(questionId, chatMessage.nickname(), answer); | ||
| String correctUser, String answer) { | ||
| return new QuestionResultResponse(correctUser, answer); | ||
| } | ||
|
|
||
| public static RankUpdateResponse toRankUpdateResponse(Room room) { | ||
|
|
@@ -107,4 +111,11 @@ public static RankUpdateResponse toRankUpdateResponse(Room room) { | |
| .map(player -> new Rank(player.getNickname(), player.getCorrectCount())) | ||
| .toList()); | ||
| } | ||
|
|
||
| public static QuestionStartResponse toQuestionStartResponse(Room room, int delay) { | ||
| return new QuestionStartResponse( | ||
| room.getCurrentQuestion().getId(), | ||
| room.getCurrentRound(), | ||
| Instant.now().plusSeconds(delay)); | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,7 @@ public class GameSetting { | |
|
|
||
| private Long quizId; | ||
| private Integer round; // 게임 변경 시 해당 게임의 총 문제 수로 설정 | ||
| private int timeLimit = 60; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이부분 전 캐치 못하고있었는뎁 감사합니다 ~! |
||
| private int timeLimit; | ||
|
|
||
| public boolean validateQuizId(Long quizId) { | ||
| return Objects.equals(this.quizId, quizId); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[L2-변경협의]
cancelTimer 직전 시점에 timeout으로 인해 handleTimeout이 호출되는 edge case가 존재할 것 같습니다.
이 경우를 대비해 cancelTimer 메서드에 timer가 이미 정지된 상태인지 알려주는 boolean return 값을 부여하고,
이를 통해 조건문 처리를 하면 좋을 것 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cancelTimer()호출 시점을chat()메서드 초반에 호출하는 방식으로 리팩토링해보겠습니다.근데, timer가 이미 정지된 상태인지 알려주는 boolean return 값이 왜 필요한지 잘 모르겠는데, 혹시 더 설명해주실 수 있으실까요?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cancelTimer 호출 시 timer가 정지 상태라는 것은 handleTimeout이 먼저 호출됐다는 뜻일 겁니다.
그렇다면 handleTimeout 로직에 따라 Question Result와 System Notice가 브로드캐스트 된 이후 새로운 timer의 start와 Question Start를 진행하는 과정을 거치고 있을 텐데, chat 메서드 내의 cancelTimer 호출 이후 같은 로직을 진행하면 오동작을 일으킬 가능성이 존재할 것 같습니다.
따라서 boolean return 값을 통해 분기 처리를 해서 같은 로직을 진행하지 않도록 하는게 좋을 것 같다는 의견이었습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오.. 그렇군요 ! 이해했습니다. 리뷰를 읽고 생각을 해봤는데,, 채팅으로 정답을 맞혔을 때, 요청을 처리하는 도중 타임아웃이 된 경우를 생각하다보니,, 동시성까지 생각해야 해서 생각이 많아졌습니다..! 혹시 이 부분은 좀 더 생각해보고 다음 PR에 반영하도록 하겠습니다 !!! 감사합니다 ! :)