Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ Double calculateMentoringAverageRating(
SELECT r
FROM Review r
WHERE r.reservation.mentoring.id = :mentoringId
ORDER BY r.createDate DESC
""")
Page<Review> findAllByMentoringId(
@Param("mentoringId") Long mentoringId,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import org.springframework.data.domain.Page;
import org.springframework.data.domain.PageRequest;
import org.springframework.data.domain.Pageable;
import org.springframework.data.domain.Sort;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;

Expand All @@ -26,7 +27,11 @@ public class ReviewService {

@Transactional(readOnly = true)
public Page<ReviewResponse> getReviews(Long mentoringId, int page, int size) {
Pageable pageable = PageRequest.of(page, size);
Pageable pageable = PageRequest.of(
page,
size,
Sort.by(Sort.Direction.DESC, "createDate")
);

return reviewRepository.findAllByMentoringId(mentoringId, pageable)
.map(ReviewResponse::from);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ Optional<Reservation> findByIdAndMember(
SELECT r
FROM Reservation r
WHERE r.mentor.member.id = :memberId
ORDER BY r.mentorSlot.startDateTime DESC
""")
Page<Reservation> findAllByMentorMember(
@Param("memberId") Long memberId,
Expand All @@ -44,7 +43,6 @@ Page<Reservation> findAllByMentorMember(
SELECT r
FROM Reservation r
WHERE r.mentee.member = :member
ORDER BY r.mentorSlot.startDateTime DESC
""")
Page<Reservation> findAllByMenteeMember(
@Param("member") Member member,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import org.springframework.data.domain.Page;
import org.springframework.data.domain.PageRequest;
import org.springframework.data.domain.Pageable;
import org.springframework.data.domain.Sort;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;

Expand All @@ -39,7 +40,11 @@ public class ReservationService {

@Transactional(readOnly = true)
public Page<ReservationDto> getReservations(Member member, int page, int size) {
Pageable pageable = PageRequest.of(page, size);
Pageable pageable = PageRequest.of(
page,
size,
Sort.by(Sort.Direction.DESC, "mentorSlot.startDateTime")
);

Page<Reservation> reservations;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -157,15 +157,13 @@ private LocalDate findNextOrSameDayOfWeek(LocalDate startDate, DayOfWeek targetD
* 매 시간 30분에 지난 슬롯 만기 처리
* - AVAILABLE -> EXPIRED
*/
@Scheduled(cron = "0 */30 * * * *")
@Scheduled(cron = "0 */30 * * * *", zone = "Asia/Seoul")
@Transactional
public void expirePassedSlots() {
LocalDateTime now = LocalDateTime.now();

int updateCount = mentorSlotRepository.expirePassedSlots(now);
if (updateCount > 0) {
log.info("만료된 슬롯 {}개 업데이트 완료 at {}", updateCount, now);
}

log.info("만료된 슬롯 {}개 업데이트 완료 at {}", updateCount, now);
}


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,7 @@
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;
import org.springframework.data.domain.Page;
import org.springframework.data.domain.PageImpl;
import org.springframework.data.domain.PageRequest;
import org.springframework.data.domain.Pageable;
import org.springframework.data.domain.*;
import org.springframework.test.util.ReflectionTestUtils;

import java.time.LocalDateTime;
Expand Down Expand Up @@ -96,16 +93,16 @@ void getReservations() {
// given
int page = 1;
int size = 5;
Pageable pageable = PageRequest.of(page, size);

Page<Reservation> reservationPage = new PageImpl<>(
List.of(reservation),
pageable,
PageRequest.of(page, size),
10
);

when(reservationRepository.findAllByMentorMember(mentor.getMember().getId(), pageable))
.thenReturn(reservationPage);
when(reservationRepository.findAllByMentorMember(
eq(mentor.getMember().getId()),
any(Pageable.class)
)).thenReturn(reservationPage);

// when
Page<ReservationDto> result = reservationService.getReservations(
Expand All @@ -119,7 +116,10 @@ void getReservations() {
assertThat(result.getSize()).isEqualTo(5);
assertThat(result.getTotalElements()).isEqualTo(10);
assertThat(result.getTotalPages()).isEqualTo(2);
verify(reservationRepository).findAllByMentorMember(mentor.getMember().getId(), pageable);
verify(reservationRepository).findAllByMentorMember(
eq(mentor.getMember().getId()),
any(Pageable.class)
);
}
}

Expand Down