[fix]DTO 수정 및 SQL 변경, CocktailShareController 리펙토링#203 #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MEOHIN
approved these changes
Oct 1, 2025
| ); | ||
| return ResponseEntity.ok(RsData.successOf(response)); | ||
| }) | ||
| .orElseGet(() -> ResponseEntity.status(HttpStatus.NOT_FOUND) |
Collaborator
There was a problem hiding this comment.
칵테일이 없는 경우는 없을 거라서 예외 발생이 필요없어진 거죵?
Collaborator
Author
There was a problem hiding this comment.
orElseGet()을 제거한 이유는 Service에서 칵테일이 없으면 orElseThrow예외를 던지도록 구조를 바꾸었기 때문입니당.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 기능 설명
DTO 수정 및 SQL 변경, CocktailShareController 리펙토링
연결된 issue
close #203
🩷 Approve 하기 전 확인해주세요!
✅ 체크리스트