Skip to content

[REFACTOR]: 베이스시나리오Id 조회위한 DTO 수정 #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2025
Merged

[REFACTOR]: 베이스시나리오Id 조회위한 DTO 수정 #108

merged 2 commits into from
Oct 13, 2025

Conversation

@johnbosco0414
Copy link
Collaborator

@johnbosco0414 johnbosco0414 commented Oct 13, 2025 •
edited by lcs9317
Loading

제목(필수): [TYPE]: 제목 예) [FEAT]: 회원가입 기능 추가

제목 규칙 자세히 보기
  • 형식: [TYPE]: 제목
  • 제한: 50자 이내, 첫 글자 대문자, 명령문
  • TYPE: FEAT FIX REFACTOR COMMENT STYLE TEST CHORE INIT

무엇을 / 왜

  • 무엇(What):
  • ScenarioDetailResponse에 baselineId를 추가했습니다.
  • 왜(Why):
  • DecisionlineId를 통한 시나리오Id 조회시 비교분석용 baselineid도 받아올수있게하기위함입니다.

어떻게(요약) — 3줄 이내

  • ScenarioDetailResponse에 baselineId를 추가했습니다.

영향 범위

  • API 변경
  • DB 마이그레이션
  • Breaking Change
  • 보안/권한 영향
  • 문서/가이드 업데이트 필요

체크리스트

  • 타입 라벨 부착 (FEAT/FIX/REFACTOR/COMMENT/STYLE/TEST/CHORE/INIT)
  • 로컬/CI 테스트 통과
  • 영향도 점검 완료
  • 주석/문서 반영(필요 시)

ToDo (선택)

  • 할 일 1
  • 할 일 2

스크린샷/증빙(선택)

이슈 연결 (자동)

Closes #109

@johnbosco0414 johnbosco0414 self-assigned this Oct 13, 2025
@johnbosco0414 johnbosco0414 added the REFACTOR 리팩토링 label Oct 13, 2025
@lcs9317 lcs9317 mentioned this pull request Oct 13, 2025
Closed
11 tasks
lcs9317
lcs9317 approved these changes Oct 13, 2025
View reviewed changes
Copy link
Collaborator

@lcs9317 lcs9317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다 고생하셨습니다

simount3
simount3 approved these changes Oct 13, 2025
View reviewed changes
Copy link
Collaborator

@simount3 simount3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

Gooraeng
Gooraeng approved these changes Oct 13, 2025
View reviewed changes
Copy link
Collaborator

@Gooraeng Gooraeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다. 감사합니다!!

shihan00321
shihan00321 approved these changes Oct 13, 2025
View reviewed changes
Copy link
Collaborator

@shihan00321 shihan00321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

@johnbosco0414 johnbosco0414 merged commit a7778a5 into main Oct 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shihan00321 shihan00321 shihan00321 approved these changes

@Gooraeng Gooraeng Gooraeng approved these changes

@lcs9317 lcs9317 lcs9317 approved these changes

@simount3 simount3 simount3 approved these changes

Assignees

@johnbosco0414 johnbosco0414

Labels

REFACTOR 리팩토링

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[REFACTOR]: 베이스시나리오Id 조회위한 DTO 수정

6 participants

@johnbosco0414 @shihan00321 @Gooraeng @lcs9317 @simount3