Skip to content

Don't get confused with default message #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wied03 merged 4 commits into from
Dec 22, 2025
Merged

Don't get confused with default message #103

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23964e1
Don't get confused with default message
wied03 Dec 22, 2025
349f485
Do not use mocks for this particular case
wied03 Dec 22, 2025
a889eb1
Better test messages
wied03 Dec 22, 2025
ab37b47
Test that out of the box Jackson message works
wied03 Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/primeframework/mvc/content/json/BaseJacksonContentHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ private void addFieldError(InvalidFormatException e) {
Matcher matchesEnumNotValidValue = invalidEnumerationValue.matcher(messageText);
String message = null;
if (matchesEnumNotValidValue.matches() && matchesEnumNotValidValue.groupCount() == 2) {
code = "[invalid]%s".formatted(field);
code = "[invalidEnum]%s".formatted(field);
Copy link
Contributor

@spwitt spwitt Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalidEnum feels a little off to me, but I can't put my finger on why. Too Java focused? Too much detail?

Is there something more generic like invalidOption or invalidSelection that would work?

If no one else has an issue, we can keep it.

Copy link
Contributor Author

@wied03 wied03 Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Push includes this change. Arguably not a patch release. In practice, not sure how much matters.

// if we have an invalid enum value, provide a better message
String possibleValues = matchesEnumNotValidValue.group(2);
String valueUsed = matchesEnumNotValidValue.group(1);
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/primeframework/mvc/content/json/JacksonContentHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,15 +103,15 @@ public void enum_values(boolean nested) throws IOException {
request.setContentType("application/json");

MessageProvider messageProvider = createStrictMock(MessageProvider.class);
expect(messageProvider.getMessage(eq(nested ? "[invalid]nested.fruit" : "[invalid]fruit"),
expect(messageProvider.getMessage(eq(nested ? "[invalidEnum]nested.fruit" : "[invalidEnum]fruit"),
eq(nested ? "bar" : "foo"),
eq("Apple, Orange"))).andReturn("Bad value");
replay(messageProvider);

MessageStore messageStore = createStrictMock(MessageStore.class);
messageStore.add(new SimpleFieldMessage(MessageType.ERROR,
nested ? "nested.fruit" : "fruit",
nested ? "[invalid]nested.fruit" : "[invalid]fruit",
nested ? "[invalidEnum]nested.fruit" : "[invalidEnum]fruit",
"Bad value"));
replay(messageStore);

Expand Down