MainView materialfx #190

Anastasia-Nikitina · 2023-04-28T20:16:19Z

No description provided.

Alexander-Ploskin · 2023-05-25T11:12:12Z

Use a small logo for icons, otherwise it is not visible.
Left panel is jerking.
Trimmed text.
Outdated placeholder for empty selection.
Wrong position for layer settings popup.
Checkbox doesn't switch when I click on element outside checkbox itself.
Select all checkbox doesn't work at all.
Image view checkboxes hidden from the start and out of sync with files checkboxes.
Wrong position for "One color" checkbox.
Wrong left margin.
No selection style from the start and wrong corner radius.
"Cancel" button doesn't cancel anything, rename it.
"Open importer" button doesn't drop shadow.
Conflict checkbox styles.
Too much empty space.
No Shift key to select range of frames.
Wrong styles:
May 25, 2023 1:57:29 PM javafx.css.CssParser declaration WARNING: CSS Error parsing '*{-fx-font-style: 'Roboto Condensed'; -fx-font-weight: 700; -fx-background-color: #78909C; -fx-text-fill: #FFFFFF;}: Expected '<font-style>' while parsing '-fx-font-style' at [1,18] May 25, 2023 1:58:55 PM javafx.css.CssParser declaration WARNING: CSS Error parsing '*{-fx-font-style: 'Roboto Condensed'; -fx-font-size: 14px; -fx-text-fill: #000000}: Expected '<font-style>' while parsing '-fx-font-style' at [1,18] May 25, 2023 1:58:55 PM javafx.css.CssParser term WARNING: CSS Error parsing css://solve.styles.SettingsDialogStylesheet: Unexpected token ';' at [27,26]
Weird.
Too big fonts.
Too big font.
Non-material marker.
Wrong text style for placeholders.
Wrong border style.
Strange lines.

src/main/kotlin/solve/catalogue/CatalogueUtils.kt

src/main/kotlin/solve/catalogue/view/CatalogueSettingsView.kt

src/main/kotlin/solve/styles/SettingsDialogStylesheet.kt

Alexander-Ploskin · 2023-06-09T09:35:27Z

src/main/kotlin/solve/catalogue/view/CatalogueSettingsView.kt

+        style = "-fx-font-family: ${Style.FontCondensed}; -fx-font-weight: ${Style.FontWeightBold};"
+    }
+
+    var segmentedButton = SegmentedButton(fileNameViewRadioButton, imagePreviewRadioButton)


avoid public fields

Alexander-Ploskin · 2023-06-09T09:36:21Z

src/test/kotlin/solve/unit/importer/ImporterTests.kt

+        const val pathTestProject = "testData/TestProject1"
+        const val image1 = "123456789"
+        const val image2 = "987654321"
+        const val layer = "alg1_keypoint"
+        const val pathImage1 = "testData/TestProject1/images/123456789.jpg"
+        const val pathImage2 = "testData/TestProject1/images/987654321.jpg"
+        const val pathOutput1 = "testData/TestProject1/alg1_keypoint/123456789.csv"
+        const val pathOutput2 = "testData/TestProject1/alg1_keypoint/987654321.csv"


Name from capital letter

Alexander-Ploskin · 2023-06-09T09:38:17Z

src/main/resources/icons/logo.png

Avoid text in small logos, it will be better to use something like that

Also, make background transparent

Alexander-Ploskin · 2023-06-09T09:41:23Z

src/main/kotlin/solve/utils/MFXUtils.kt

@@ -0,0 +1,76 @@
+package solve.utils


duplicates solve.utils.materialfx.MFXNodesUtils

Alexander-Ploskin · 2023-06-09T09:43:00Z

src/main/kotlin/solve/styles/TreeTableViewStylesheet.kt

        treeTableRowCell {
            arrow {
-                backgroundImage += URI("/icons/importer/Shape.png")
+                backgroundImage += URI("/icons/importer/list_cell_arrow.png")


Why not svg?

Alexander-Ploskin · 2023-06-09T10:27:14Z

src/main/kotlin/solve/settings/visualization/popover/LayerSettingsPopOverNode.kt

+                    dialogClosingController.isClosing.value = true
+                    dialogClosingController.isClosing.value = false


Incapsulate in method

Alexander-Ploskin · 2023-06-09T10:27:55Z

src/main/kotlin/solve/settings/visualization/popover/SettingsDialogNode.kt

+import tornadofx.*
+
+class SettingsDialogNode : VBox(10.0) {
+


Alexander-Ploskin · 2023-06-09T10:28:47Z

src/main/kotlin/solve/settings/visualization/popover/PointLayerSettingsPopOverNode.kt

        )
-        addSettingField("One color", buildLandmarkUseOneColorCheckBox(pointLayerSettings), Alignment.Left)
+        addSettingField(
+            "",


more convenient to move the title to the checkbox

Alexander-Ploskin · 2023-06-09T10:29:29Z

src/main/kotlin/solve/settings/visualization/popover/SettingsDialogNode.kt

+
+    var title: String = ""
+
+    fun addTitle() {


Why it is not added from the start?

Because the title contains the name of the markup file. Title is added when the type of landmark is already known

Alexander-Ploskin · 2023-06-09T10:29:46Z

src/main/kotlin/solve/settings/visualization/popover/SettingsDialogNode.kt

+
+class SettingsDialogNode : VBox(10.0) {
+
+    var title: String = ""


public field? Why it is mutable?

field is public because its value is set in another class, when possible define title

Alexander-Ploskin · 2023-06-09T10:31:31Z

src/main/kotlin/solve/catalogue/view/CatalogueSettingsView.kt

+            hbox(130) {
+                addStylesheet(CatalogueViewStylesheet::class)
+                maxWidth = 500.0
+                padding = Insets(0.0, 0.0, 0.0, 0.0)


use paddingall

Alexander-Ploskin · 2023-06-09T10:42:16Z

Problems:

Placeholder text is trimmed from the start.
Wrong layout.
Slider label is hidden from the start.
Filters is not shown.
Invalid scrollbar position on resizing.
Catalogue tab button loses selected state on second click.
Wrong appearance on layer drag-drop.
Apply button and filter panel is lost after no frames was applied.

Anastasia-Nikitina · 2023-06-19T13:50:54Z

comment 1, point 6. It is embedded in the MFXCheckList, also works in demo

Anastasia-Nikitina marked this pull request as draft April 28, 2023 20:56

Anastasia-Nikitina force-pushed the side-panels-materialfx branch 2 times, most recently from eed3d14 to 79a2acb Compare May 8, 2023 22:13

Anastasia-Nikitina force-pushed the main-view-materialfx branch 2 times, most recently from 1f957a5 to c596cb1 Compare May 21, 2023 00:10

Anastasia-Nikitina changed the base branch from side-panels-materialfx to filter-panel May 21, 2023 18:05

Anastasia-Nikitina force-pushed the main-view-materialfx branch from 1798439 to 36d5c70 Compare May 21, 2023 19:30

Anastasia-Nikitina and others added 23 commits May 22, 2023 21:25

\added materialfx dialogs and fixed some bugs

907069b

removed commented code

d899297

added new style constants

d8cd2ff

added panels

d6f3da0

removed unused

92dbf3a

added borderpane and spaces

5bf682c

added importAction

50fc61a

spaces and added paddingAll

8173d44

fixes

8b47503

removed unused

642865e

added grid tab

c4726fd

removed grid button

b054f53

removed unused

75133ac

added correct icons

1f44155

by inject()

9176b58

Just an automaticly formatted codestyle

222fe0c

Wildcards fix

fc66c14

added materialfx dialogs and fixed some bugs

e110d27

removed commented code

9fcc802

added new style constants

c56eed7

added panels

2edfa45

changed SidePanelTab class

7463506

fixes

b4bfb50

Anastasia-Nikitina added 6 commits May 22, 2023 22:01

added design for settings dialog

afdb8a1

added svg placeholder

266cc65

added icon

2245262

removed companion object

1aaddd3

removed or commented unused

6a7018b

rebase

5fc3155

Anastasia-Nikitina force-pushed the main-view-materialfx branch from 36d5c70 to 5fc3155 Compare May 22, 2023 19:03

Anastasia-Nikitina marked this pull request as ready for review May 23, 2023 09:29

codestyle

2c9513d

Alexander-Ploskin suggested changes May 25, 2023

View reviewed changes

Anastasia-Nikitina added 9 commits May 28, 2023 14:59

codestyle

eb93adf

removed png

2309551

fixed svg

56cf352

changed logo

5add380

fixed disabling button

f00e48e

fixed some bugs

9d07887

added val instead of var

bf88422

removed unused

d513985

fixed tabs and spaces

0063811

Alexander-Ploskin suggested changes Jun 9, 2023

View reviewed changes

Anastasia-Nikitina added 3 commits June 12, 2023 17:00

removed unused

24c1013

fixes

039bb55

fixed linter warning

0f138b9

Anastasia-Nikitina linked an issue Jun 18, 2023 that may be closed by this pull request

Problems of new design #211

Open

Anastasia-Nikitina added 2 commits June 19, 2023 19:43

fixed problems

689ee22

fixed linter warning

e45f8c2

		dialogClosingController.isClosing.value = true
		dialogClosingController.isClosing.value = false


		class SettingsDialogNode : VBox(10.0) {

		var title: String = ""

MainView materialfx #190

Are you sure you want to change the base?

MainView materialfx #190

Uh oh!

Conversation

Anastasia-Nikitina commented Apr 28, 2023

Uh oh!

Alexander-Ploskin commented May 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Alexander-Ploskin commented Jun 9, 2023

Uh oh!

Anastasia-Nikitina commented Jun 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Alexander-Ploskin commented May 25, 2023 •

edited

Loading