Add ngStyle binding to content wrapper div #19121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem The `style` input property is declared but never applied in the template. The `styleClass` input is applied to the host element, but users typically want to style the visible content wrapper. ## Current Behavior ```html Content ``` - `style` is ignored completely - `styleClass="mt-2"` applies to `<p-message>` host, not the visible content div ## Expected Behavior - `style` should apply inline styles to the content wrapper - `styleClass` should apply classes to the content wrapper (where it's visually effective) ## Changes - Added `[ngStyle]="style"` to content wrapper div - Moved `styleClass` from host binding to content wrapper - Host element retains only base component classes ## Breaking Changes None - this fixes currently non-functional behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
styleinput property is declared but never applied in the template. ThestyleClassinput is applied to the host element, but users typically want to style the visible content wrapper.Current Behavior
styleis ignored completelystyleClass="mt-2"applies to<p-message>host, not the visible content divExpected Behavior
styleshould apply inline styles to the content wrapperstyleClassshould apply classes to the content wrapper (where it's visually effective)Changes
[ngStyle]="style"to content wrapper divstyleClassfrom host binding to content wrapperBreaking Changes
None - this fixes currently non-functional behavior
Defect Fixes
When submitting a PR, please also create an issue documenting the error and manually link to an issue.
Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
Smaller scaled feature implementations such as adding a property to a component will be considered for merging.