fix: #16776 Select - Fix label association for better accessibility #19230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sibility Fixes primefaces#16776 The span-element is not labelable. see https://developer.mozilla.org/en-US/docs/Web/HTML/Guides/Content_categories#labelable The element with the id referenced by the label must be labelable. Button is a labelable element.
|
@jjanzon is attempting to deploy a commit to the cetincakiroglu's projects Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16776
The span-element is not labelable. see https://developer.mozilla.org/en-US/docs/Web/HTML/Guides/Content_categories#labelable The element with the id referenced by the label must be labelable. Button is a labelable element.
Defect Fixes
When submitting a PR, please also create an issue documenting the error and manually link to an issue.
Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
Smaller scaled feature implementations such as adding a property to a component will be considered for merging.