Skip to content

fix(DataTable): apply bottom border width in dataTable footer #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KumJungMin wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(DataTable): apply bottom border width in dataTable footer #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28aa30a
fix: apply bottom border width in dataTable footer
KumJungMin Sep 1, 2024
e9b6742
fix: apply hex color in border line
KumJungMin Sep 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 2 additions & 16 deletions theme-base/components/data/_datatable.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,10 +266,10 @@
.p-datatable-tfoot {
> tr {
> td {
border-width: 1px 0 1px 1px;
border-width: 0 0 1px 1px;

&:last-child {
border-width: 1px 1px 1px 1px;
border-width: 0 1px 1px 1px;
}
}
}
Expand Down Expand Up @@ -298,20 +298,6 @@
}
}
}

&:has(.p-datatable-tbody):has(.p-datatable-tfoot) .p-datatable-tbody {
> tr {
&:last-child {
> td {
border-width: 0 0 0 1px;

&:last-child {
border-width: 0 1px 0 1px;
}
}
}
}
}
}

&.p-datatable-striped {
Expand Down
2 changes: 1 addition & 1 deletion themes/material/material-dark/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ $tableFooterCellPadding: 1rem 1rem !default;
$tableFooterCellBg: #1e1e1e !default;
$tableFooterCellTextColor: $textColor !default;
$tableFooterCellFontWeight: 500 !default;
$tableFooterCellBorder: 1px solid 3404040 !default;
$tableFooterCellBorder: 1px solid #404040 !default;
Copy link
Author

@KumJungMin KumJungMin Sep 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • i change color to hex :)

$tableFooterCellBorderWidth: 0 0 1px 0 !default;
$tableResizerHelperBg: $primaryColor !default;
$tableDragHelperBg: rgba($primaryColor, 0.16) !default;
Expand Down