Conversation
🦋 Changeset detectedLatest commit: 9d3c0db The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🔍 Design token changes foundView CSS variable changes+ --brand-RiverBreakout-variant-gridline-spacing-contentGap: var(--base-size-16);+ --brand-RiverBreakout-variant-gridline-spacing-outerInline: var(--base-size-20);+ --brand-RiverBreakout-variant-gridline-spacing-outerBlockEnd: var(--base-size-40);+ --brand-RiverBreakout-variant-gridline-spacing-outerBlock: var(--base-size-36);- --brand-River-spacing-outer: var(--base-size-36);
+ --brand-River-variant-gridline-spacing-outerInline: var(--base-size-20);+ --brand-River-variant-gridline-spacing-outerBlock: var(--base-size-40);+ --brand-River-spacing-outerBlock: var(--base-size-36);- --brand-River-spacing-inner: var(--base-size-24);
+ --brand-River-spacing-inner: var(--base-size-40);+ --brand-RiverBreakout-variant-gridline-spacing-contentGap: var(--base-size-20);+ --brand-RiverBreakout-variant-gridline-spacing-outerInline: var(--base-size-36);+ --brand-RiverBreakout-variant-gridline-spacing-outerBlockEnd: var(--base-size-48);+ --brand-RiverBreakout-variant-gridline-spacing-outerBlock: var(--base-size-40);+ --brand-RiverBreakout-variant-gridline-spacing-contentGap: var(--base-size-24);+ --brand-RiverBreakout-variant-gridline-spacing-outerInline: var(--base-size-64);+ --brand-RiverBreakout-variant-gridline-spacing-outerBlockEnd: var(--base-size-80);+ --brand-RiverBreakout-variant-gridline-spacing-outerBlock: var(--base-size-64);- --brand-River-spacing-outer: var(--base-size-48);
+ --brand-River-variant-gridline-spacing-outerInline: var(--base-size-64);+ --brand-River-variant-gridline-spacing-outerBlock: var(--base-size-64);+ --brand-River-spacing-outerBlock: var(--base-size-48);- --brand-River-spacing-inner: var(--base-size-48);
+ --brand-River-spacing-inner: var(--base-size-24); |
🟢 Unit test coverage changes foundUnit test coverage has been updated through this PR. Changes: 1 new tests, 0 removed tests, 2 improved, 0 decreased
|
|
There was a problem hiding this comment.
Pull request overview
This PR implements the 2026 brand refresh for the River component with backwards-compatible updates and introduces a new EyebrowText component.
Changes:
- Added new
EyebrowTextcomponent for use as a small text label above headings - Introduced
variantprop to River with newgridlineoption for bordered grid layouts - Added
imageBackgroundColorprop toRiver.Visualfor background treatments - Updated River spacing design tokens and added support for new variants
Reviewed changes
Copilot reviewed 10 out of 567 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/EyebrowText/* | New component files including implementation, tests, stories, and styles |
| packages/design-tokens/src/tokens/functional/components/river/river.json | Updated spacing tokens and added gridline variant configuration |
| apps/next-docs/content/components/River/react.mdx | Documentation for new River variants and imageBackgroundColor prop |
| apps/next-docs/content/components/River/react.tsx | Export new defaultRiverVariant constant |
| .changeset/wide-seed-sky.md | Release notes describing new features |
packages/design-tokens/src/tokens/functional/components/river/river.json
Show resolved
Hide resolved
…actor-update-river-component
simmonsjenna
left a comment
There was a problem hiding this comment.
@danielguillan These three new variants are now getting affected by too much spacing on the left of the copy (intended left/right padding would be balanced for these):
|
@simmonsjenna the current spacing in these is consistent with the designs in Figma. But I understand why it feels unbalanced. Since these variants are non-blocking, I'm happy to revisit the spacing in a follow-up.
Gridline + background + 50:50 — Storybook - Figma
|
Dismissing to unblock release. We'll follow up on final fixes as they only affect grid lines.
…actor-update-river-component






Summary
Towards https://github.com/github/brand-marketing-design/issues/2606
Aligns the River component to the 2026 brand refresh.
🔗 Storybook
List of notable changes:
Based on the changes made (renamed
bordered-gridtogridline, replacedhasBackgroundwithimageBackgroundColor), here's the updated description:EyebrowTextcomponent, a simplified text label for use above headingsvariantprop withgridlineoptionimageBackgroundColorprop onRiver.Visualfor full-bleed container with subtle backgroundalignprop onRiver.Contentfor optionalblock-endvertical alignmentEyebrowTextas a child ofRiver.ContentRiver.VisualWhat should reviewers focus on?
bordered-grid)hasBackgroundvisual treatment at different viewport sizes (mobile, tablet, desktop)Steps to test:
Contributor checklist:
update snapshotslabel to the PR)Reviewer checklist: