Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR implements a hotfix for the unreleased SubNav component, addressing padding inconsistencies and removing unnecessary Mozilla Firefox-specific CSS overrides. The changes improve visual alignment and simplify the CSS by eliminating browser-specific workarounds that are no longer needed.
Changes:
- Adjusted padding on active link pills in mobile overlay to use asymmetric values for better optical alignment
- Removed optical alignment hack (top: 1px) that was previously applied to all overlay links
- Removed Firefox-specific CSS overrides that are no longer necessary
Reviewed changes
Copilot reviewed 1 out of 15 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/react/src/SubNav/SubNav.module.css |
Updated padding from 2-value to 3-value shorthand for active links in overlay (line 373), removed optical alignment adjustment (lines 595-596), and removed Firefox-specific @supports block (lines 713-717) |
| Visual snapshot files (8 PNG files) | Auto-generated visual regression test snapshots updated to reflect the CSS padding and alignment changes |
🟢 No design token changes found |
🟢 No unit test coverage changes foundAll components and hooks with tests maintain the same coverage as the main branch. |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
Summary
Towards https://github.com/github/brand-marketing-design/issues/2606
Patches the unreleased features for SubNav, specifically:
List of notable changes:
Steps to test:
Supporting resources (related issues, external links, etc):
Contributor checklist:
update snapshotslabel to the PR)Reviewer checklist:
Screenshots: