Replace @import with @use for theme styles#2941
Closed
prashant2007-wq wants to merge 1 commit intoprimer:mainfrom
Closed
Replace @import with @use for theme styles#2941prashant2007-wq wants to merge 1 commit intoprimer:mainfrom
prashant2007-wq wants to merge 1 commit intoprimer:mainfrom
Conversation
This commit addresses issue primer#2781 by migrating from deprecated @import statements to the modern @use directive in color-modes/index.scss. Changes: - Replaced all @import statements with @use - This removes Sass deprecation warnings - Follows Sass module system best practices
|
Member
|
Thanks for the PR @prashant2007-wq , we've attempted this approach before but determined this migration will need more in-depth work to be compatible with our internal systems, so closing the PR and leaving the issue open for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2781
This PR addresses the Sass deprecation warnings by migrating from
@importto@usein the color-modes module.Changes
@importstatements with@useinsrc/color-modes/index.scss@importdirectivesRelated Issue
Closes #2781
Testing