Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR adds a CODEOWNERS file to enable automatic review assignment from the Primer Engineering team in addition to the Design team. The goal is to distribute the review load more evenly and prevent PRs from going stale.
Key Changes:
- Adds a new CODEOWNERS file in the root directory that assigns all changes to both
@primer/engineer-reviewersand@primer/design-reviewers
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,2 @@ | |||
| # All changes should be reviewed by a member of one of the following teams | |||
There was a problem hiding this comment.
Adding a CODEOWNERS file in the root directory will take precedence over the existing .github/CODEOWNERS file. GitHub prioritizes CODEOWNERS files in this order: root directory, .github/ directory, then docs/ directory. This means the specific rules in .github/CODEOWNERS (which assign both engineer-reviewers and design-reviewers to package.json and package-lock.json) will be overridden by this generic rule. Consider either updating the existing .github/CODEOWNERS file instead, or ensuring this new file includes all the specific rules from the existing file.
| # All changes should be reviewed by a member of one of the following teams | |
| # All changes should be reviewed by a member of one of the following teams | |
| /package.json @primer/engineer-reviewers @primer/design-reviewers | |
| /package-lock.json @primer/engineer-reviewers @primer/design-reviewers |
|
Closing, did not realize there was already a CODEOWNERS nested in this repo https://github.com/primer/css/blob/main/.github/CODEOWNERS |
What are you trying to accomplish?
I noticed that reviews for PRs in the
primer/cssrepo are getting auto-assigned to theprimer/design-reviewersgroup, which is not very large.The Primer Engineering team can help with these reviews. In order to enable that, I'm adding this CODEOWNERS file. Once merged, I can adjust the repo settings so that a round-robin engineer review is also assigned to review
primer/cssPRs. This should help avoid proposed changes in this repo from going stale.Can these changes ship as is?