Skip to content

Add CODEOWNERS file for review process#2947

Closed
lesliecdubs wants to merge 1 commit intomainfrom
lcw/addCodeowners
Closed

Add CODEOWNERS file for review process#2947
lesliecdubs wants to merge 1 commit intomainfrom
lcw/addCodeowners

Conversation

@lesliecdubs
Copy link
Member

What are you trying to accomplish?

I noticed that reviews for PRs in the primer/css repo are getting auto-assigned to the primer/design-reviewers group, which is not very large.

The Primer Engineering team can help with these reviews. In order to enable that, I'm adding this CODEOWNERS file. Once merged, I can adjust the repo settings so that a round-robin engineer review is also assigned to review primer/css PRs. This should help avoid proposed changes in this repo from going stale.

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@lesliecdubs lesliecdubs self-assigned this Dec 17, 2025
@lesliecdubs lesliecdubs requested a review from a team as a code owner December 17, 2025 20:12
Copilot AI review requested due to automatic review settings December 17, 2025 20:12
@changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2025

⚠️ No Changeset found

Latest commit: f4df108

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a CODEOWNERS file to enable automatic review assignment from the Primer Engineering team in addition to the Design team. The goal is to distribute the review load more evenly and prevent PRs from going stale.

Key Changes:

  • Adds a new CODEOWNERS file in the root directory that assigns all changes to both @primer/engineer-reviewers and @primer/design-reviewers

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -0,0 +1,2 @@
# All changes should be reviewed by a member of one of the following teams
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a CODEOWNERS file in the root directory will take precedence over the existing .github/CODEOWNERS file. GitHub prioritizes CODEOWNERS files in this order: root directory, .github/ directory, then docs/ directory. This means the specific rules in .github/CODEOWNERS (which assign both engineer-reviewers and design-reviewers to package.json and package-lock.json) will be overridden by this generic rule. Consider either updating the existing .github/CODEOWNERS file instead, or ensuring this new file includes all the specific rules from the existing file.

Suggested change
# All changes should be reviewed by a member of one of the following teams
# All changes should be reviewed by a member of one of the following teams
/package.json @primer/engineer-reviewers @primer/design-reviewers
/package-lock.json @primer/engineer-reviewers @primer/design-reviewers

Copilot uses AI. Check for mistakes.
@lesliecdubs
Copy link
Member Author

Closing, did not realize there was already a CODEOWNERS nested in this repo https://github.com/primer/css/blob/main/.github/CODEOWNERS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants