Upgrade to ESLint v9 support with eslint-plugin-github v6 #381

Copilot · 2025-08-07T02:31:58Z

This PR upgrades eslint-plugin-primer-react to support ESLint v9, dropping backward compatibility with ESLint v8 as part of a major version release.

Background

ESLint v9 introduced significant breaking changes, most notably the deprecation of the legacy .eslintrc.* configuration format in favor of the new flat config system. This affected both how ESLint plugins are configured and how RuleTester works in test files.

Changes Made

Core Compatibility

Updated peerDependencies to require ESLint v9: "eslint": "^9.0.0"
Updated devDependencies to use ESLint v9 for development and testing
Upgraded @typescript-eslint/rule-tester to v8.38.0 for ESLint v9 compatibility
Updated eslint-plugin-github to v6.0.0 for enhanced ESLint v9 compatibility

Test Configuration Migration

ESLint v9's RuleTester requires the new flat config format instead of the legacy eslintrc format. Updated all 20 test files:

Before (eslintrc format):

const ruleTester = new RuleTester({
  parserOptions: {
    ecmaVersion: 'latest',
    sourceType: 'module',
    ecmaFeatures: { jsx: true },
  },
})

After (flat config format):

const ruleTester = new RuleTester({
  languageOptions: {
    ecmaVersion: 'latest',
    sourceType: 'module',
    parserOptions: {
      ecmaFeatures: { jsx: true },
    },
  },
})

Repository Configuration

Migrated from .eslintrc.js to eslint.config.js using the new flat config format
Properly configured both eslint:recommended and plugin:github/recommended using js.configs.recommended and github.default.getFlatConfigs().recommended
Removed deprecated .eslintignore file (now using ignores property in flat config)
Added globals package for environment variable definitions
Simplified TypeScript ESLint parser configuration in test files

Dependency Updates

eslint-plugin-github: Updated from v5.0.1 to v6.0.0, which includes better ESLint v9 support and updated TypeScript ESLint dependencies

Testing

All plugin rules work correctly with ESLint v9. The test suite shows 282/282 tests passing. Repository linting works perfectly with ESLint v9 and properly enforces both ESLint recommended rules and GitHub's recommended coding standards.

Breaking Change

This is a major version release that drops support for ESLint v8. Projects must upgrade to ESLint v9 to use this version of the plugin.

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: jonrohan <[email protected]>

changeset-bot · 2025-08-07T02:52:45Z

🦋 Changeset detected

Latest commit: 1e7533a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
eslint-plugin-primer-react	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

package.json

Co-authored-by: jonrohan <[email protected]>

Copilot

Pull Request Overview

This PR upgrades eslint-plugin-primer-react to support ESLint v9 while maintaining backward compatibility with ESLint v8, implementing the new flat config system and updating dependencies.

Updated ESLint peer dependency to support both v8 and v9 ("^8.42.0 || ^9.0.0")
Migrated all 20 test files from legacy eslintrc format to new flat config format for RuleTester
Updated eslint-plugin-github from v5.0.1 to v6.0.0 for enhanced ESLint v9 compatibility

Reviewed Changes

Copilot reviewed 25 out of 26 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
package.json	Updated ESLint peer dependency, upgraded eslint-plugin-github to v6.0.0, and reorganized dev dependencies
eslint.config.js	New flat config format ESLint configuration replacing legacy .eslintrc.js
.eslintrc.js	Removed legacy ESLint configuration file
.eslintignore	Removed ignore file (now handled in flat config)
src/rules/no-deprecated-experimental-components.js	Removed eslint-disable comment for i18n-text rule
src/rules/tests/*.test.js	Migrated 20 test files from eslintrc to flat config format for RuleTester
.changeset/great-tables-decide.md	Added changeset documenting the major version upgrade

Copilot · 2025-08-07T03:13:48Z

src/rules/__tests__/prefer-action-list-item-onselect.test.js

-  parser: require.resolve('@typescript-eslint/parser'),
-  parserOptions: {
+  languageOptions: {
+    parser: require(require.resolve('@typescript-eslint/parser', {paths: [require.resolve('eslint-plugin-github')]})),


The nested require.resolve() calls make this parser resolution complex and hard to understand. Consider simplifying to require('@typescript-eslint/parser') or storing the resolved path in a variable for better readability.

Suggested change

parser: require(require.resolve('@typescript-eslint/parser', {paths: [require.resolve('eslint-plugin-github')]})),

parser: require('@typescript-eslint/parser'),

Copilot · 2025-08-07T03:13:49Z

src/rules/__tests__/no-wildcard-imports.test.js

-  parser: require.resolve('@typescript-eslint/parser'),
-  parserOptions: {
+  languageOptions: {
+    parser: require(require.resolve('@typescript-eslint/parser', {paths: [require.resolve('eslint-plugin-github')]})),


The nested require.resolve() calls make this parser resolution complex and hard to understand. Consider simplifying to require('@typescript-eslint/parser') or storing the resolved path in a variable for better readability.

Suggested change

parser: require(require.resolve('@typescript-eslint/parser', {paths: [require.resolve('eslint-plugin-github')]})),

parser: require('@typescript-eslint/parser'),

Copilot · 2025-08-07T03:13:49Z

src/rules/__tests__/no-unnecessary-components.test.js

-    tsconfigRootDir: path.resolve(__dirname, 'fixtures'),
-    project: path.resolve(__dirname, 'fixtures', 'tsconfig.json'),
+  languageOptions: {
+    parser: require(require.resolve('@typescript-eslint/parser', {paths: [require.resolve('eslint-plugin-github')]})),


The nested require.resolve() calls make this parser resolution complex and hard to understand. Consider simplifying to require('@typescript-eslint/parser') or storing the resolved path in a variable for better readability.

Suggested change

parser: require(require.resolve('@typescript-eslint/parser', {paths: [require.resolve('eslint-plugin-github')]})),

parser: require(typescriptEslintParserPath),

src/rules/__tests__/no-unnecessary-components.test.js

…4464

joshblack · 2025-08-07T18:05:47Z

eslint.config.js

@copilot during the migration, this file seems to hav removed extends: ['eslint:recommended', 'plugin:github/recommended'],. Can you update the config to extend from these configurations but in the new format for eslint v9?

Updated eslint.config.js to include both eslint:recommended and plugin:github/recommended configurations in the new flat config format for ESLint v9. The config now properly extends from these configurations using js.configs.recommended and github.default.getFlatConfigs().recommended with appropriate rule overrides for this repository. Commit: c9d0514

joshblack · 2025-08-07T18:06:16Z

package.json

@@ -28,30 +28,31 @@
  },
  "homepage": "https://github.com/primer/eslint-plugin-primer-react#readme",
  "peerDependencies": {
-    "eslint": "^8.42.0"
+    "eslint": "^8.42.0 || ^9.0.0"


If we're doing a major for this release, maybe we could just do ^9.0.0 instead of dual support? Curious what you think @jonrohan

Was thinking the same thing

joshblack · 2025-08-07T18:07:13Z

src/rules/__tests__/no-unnecessary-components.test.js

-  parserOptions: {
-    tsconfigRootDir: path.resolve(__dirname, 'fixtures'),
-    project: path.resolve(__dirname, 'fixtures', 'tsconfig.json'),
+  languageOptions: {


@copilot Use the config from typescript-eslint instead of @typescript-eslint/parser

Updated the test file to use the direct @typescript-eslint/parser import instead of the complex require resolution path. This simplifies the configuration and follows the standard typescript-eslint usage pattern. Commit: c9d0514

…recommended configs and update typescript-eslint parser usage Co-authored-by: joshblack <[email protected]>

jonrohan · 2025-08-07T18:59:30Z

package.json

@@ -28,30 +28,36 @@
  },
  "homepage": "https://github.com/primer/eslint-plugin-primer-react#readme",
  "peerDependencies": {
-    "eslint": "^8.42.0"
+    "eslint": "^8.42.0 || ^9.0.0"


@copilot

Suggested change

"eslint": "^8.42.0 || ^9.0.0"

"eslint": "^9.0.0"

Updated ESLint peerDependency to require only v9.0.0, removing backward compatibility with v8 as suggested. This aligns with the major version release approach. All tests pass and linting works correctly with ESLint v9. Commit: 1e7533a

Co-authored-by: jonrohan <[email protected]>

Initial plan

f5798e0

Copilot AI assigned Copilot and jonrohan Aug 7, 2025

Copilot started work on behalf of jonrohan August 7, 2025 02:32 View session

Copilot AI and others added 2 commits August 7, 2025 02:36

Initial analysis for ESLint v9 upgrade

43e8400

Co-authored-by: jonrohan <[email protected]>

Upgrade to ESLint v9 support

aeecb55

Co-authored-by: jonrohan <[email protected]>

jonrohan reviewed Aug 7, 2025

View reviewed changes

package.json Outdated Show resolved Hide resolved

Copilot AI changed the title ~~[WIP] Can you upgrade to eslint v9~~ Upgrade to ESLint v9 support Aug 7, 2025

Copilot AI requested a review from jonrohan August 7, 2025 02:54

Copilot finished work on behalf of jonrohan August 7, 2025 02:54

Copilot started work on behalf of jonrohan August 7, 2025 02:54 View session

Update eslint-plugin-github to v6.0.0

52b801b

Co-authored-by: jonrohan <[email protected]>

Copilot AI changed the title ~~Upgrade to ESLint v9 support~~ Upgrade to ESLint v9 support with eslint-plugin-github v6 Aug 7, 2025

Copilot finished work on behalf of jonrohan August 7, 2025 03:01

jonrohan and others added 4 commits August 7, 2025 03:05

Format fix

cb41b06

Remove duplicate test cases

454a5e8

Remove duplicate output

dd1e33e

Upgrade eslint-plugin-primer-react to major version

7427e58

This was referenced Aug 7, 2025

Upgrade ESLint to V9 #287

Closed

Bump eslint-plugin-github from 5.0.1 to 6.0.0 #347

Closed

jonrohan added the skip changeset label Aug 7, 2025

jonrohan marked this pull request as ready for review August 7, 2025 03:12

Copilot AI review requested due to automatic review settings August 7, 2025 03:12

jonrohan requested a review from a team as a code owner August 7, 2025 03:12

Copilot AI reviewed Aug 7, 2025

View reviewed changes

jonrohan requested a review from TylerJDev August 7, 2025 03:19

jonrohan enabled auto-merge (squash) August 7, 2025 03:19

Merge branch 'main' into copilot/fix-6a7c9edd-41fe-4b80-a792-ea2d39c6…

5ea0b6a

…4464

jonrohan requested a review from joshblack August 7, 2025 17:59

joshblack requested changes Aug 7, 2025

View reviewed changes

Copilot started work on behalf of joshblack August 7, 2025 18:07 View session

Fix eslint.config.js to include eslint:recommended and plugin:github/…

c9d0514

…recommended configs and update typescript-eslint parser usage Co-authored-by: joshblack <[email protected]>

auto-merge was automatically disabled August 7, 2025 18:23
Head branch was pushed to by a user without write access

Copilot AI requested a review from joshblack August 7, 2025 18:24

Copilot finished work on behalf of joshblack August 7, 2025 18:24

jonrohan reviewed Aug 7, 2025

View reviewed changes

Copilot started work on behalf of jonrohan August 7, 2025 18:59 View session

Update ESLint peerDependency to require only v9.0.0

1e7533a

Co-authored-by: jonrohan <[email protected]>

Copilot AI requested a review from jonrohan August 7, 2025 19:06

Copilot finished work on behalf of jonrohan August 7, 2025 19:06

jonrohan enabled auto-merge (squash) August 7, 2025 21:00

joshblack approved these changes Aug 7, 2025

View reviewed changes

jonrohan merged commit 52f3be6 into main Aug 7, 2025
9 checks passed

jonrohan deleted the copilot/fix-6a7c9edd-41fe-4b80-a792-ea2d39c64464 branch August 7, 2025 21:43

primer-css mentioned this pull request Aug 7, 2025

Release Tracking #365

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Upgrade to ESLint v9 support with eslint-plugin-github v6 #381

Upgrade to ESLint v9 support with eslint-plugin-github v6 #381

Uh oh!

Copilot AI commented Aug 7, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Aug 7, 2025 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 7, 2025

Uh oh!

Copilot AI Aug 7, 2025

Uh oh!

Copilot AI Aug 7, 2025

Uh oh!

Uh oh!

joshblack Aug 7, 2025

Uh oh!

Copilot AI Aug 7, 2025

Uh oh!

joshblack Aug 7, 2025

Uh oh!

jonrohan Aug 7, 2025

Uh oh!

joshblack Aug 7, 2025

Uh oh!

Copilot AI Aug 7, 2025

Uh oh!

jonrohan Aug 7, 2025

Uh oh!

Copilot AI Aug 7, 2025

Uh oh!

Uh oh!

Uh oh!

	parser: require(require.resolve('@typescript-eslint/parser', {paths: [require.resolve('eslint-plugin-github')]})),
	parser: require('@typescript-eslint/parser'),

	parser: require(require.resolve('@typescript-eslint/parser', {paths: [require.resolve('eslint-plugin-github')]})),
	parser: require(typescriptEslintParserPath),

Upgrade to ESLint v9 support with eslint-plugin-github v6 #381

Upgrade to ESLint v9 support with eslint-plugin-github v6 #381

Uh oh!

Conversation

Copilot AI commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Background

Changes Made

Core Compatibility

Test Configuration Migration

Repository Configuration

Dependency Updates

Testing

Breaking Change

Uh oh!

changeset-bot bot commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

joshblack Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

joshblack Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

jonrohan Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

joshblack Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

jonrohan Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Aug 7, 2025 •

edited

Loading

changeset-bot bot commented Aug 7, 2025 •

edited

Loading