Skip to content

Add bracket safelist to IIS server rules #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rezrah wants to merge 7 commits into from
Closed

Add bracket safelist to IIS server rules #414

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2539c64
add bracket safelist to IIS server rules
rezrah Jan 26, 2026
f89f52b
remove web.config build output
rezrah Jan 26, 2026
5be20b1
use new approach to encode brackets
rezrah Jan 26, 2026
6a3315b
move rule above the trailing slash one
rezrah Jan 26, 2026
e9506c6
stop encoding brackets, pass straight through
rezrah Jan 26, 2026
aaaa86c
accept encoded, forward literal brackets
rezrah Jan 26, 2026
4c9207e
forward url without rewriting
rezrah Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions script/redirects.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,20 @@ function buildRedirects() {
<action type="Redirect" url="https://{C:2}/{R:1}" redirectType="Permanent" />
</rule>
<!--END SSL-->
<!--BEGIN Bracket-in-URL proxy - must come before trailing slash rule -->
<!-- The domain should match the catch-all route defined in redirects.json -->
<rule name="Bracket-in-URL proxy" stopProcessing="true">
<match url="^(.*)\\[([^\\]]+)\\](.*)$" ignoreCase="true" />
<conditions>
<add input="{HTTP_HOST}" pattern="^(?:www.)?(.*)$" />
</conditions>
<action type="Rewrite" url="https://primer-docs-preview.github.com{UNENCODED_URL}" appendQueryString="false" />
<serverVariables>
<set name="HTTP_X_UNPROXIED_URL" value="https://primer-docs-preview.github.com{UNENCODED_URL}" />
<set name="HTTP_X_ORIGINAL_HOST" value="{HTTP_HOST}" />
</serverVariables>
</rule>
<!--END Bracket-in-URL proxy -->
<!--BEGIN Trailing slash enforcement-->
<rule name="Add trailing slash" stopProcessing="true">
<match url="(.*[^/])$" />
Expand Down
Loading