Skip to content

Update SelectPanel.playground.stories.tsx to no longer use styled-components #6525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update SelectPanel.playground.stories.tsx to no longer use styled-components #6525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bca82a4
Initial plan
Copilot Aug 8, 2025
fb3118e
Replace Box with sx prop with CSS module in SelectPanel.playground.st…
Copilot Aug 8, 2025
7070992
Cleanup
hectahertz Aug 22, 2025
60f197a
Merge branch 'main' into copilot/fix-6523
hectahertz Aug 22, 2025
3847f59
test(vrt): update snapshots
hectahertz Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified .../SelectPanel.test.ts-snapshots/SelectPanel-Default-forced-colors-dark-linux.png
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs to be reverted since we don't want to add the snapshot with the cursor

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions packages/react/src/experimental/SelectPanel2/SelectPanel.playground.stories.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
.ColorIndicator {
width: 14px;
height: 14px;
border-radius: 100%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use var(--borderRadius-full) here for consistency with other files, but maybe not a strictly necessary change

}
Copy link
Preview

Copilot AI Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS module should be wrapped in a CSS layer as mentioned in the PR description. Add @layer primer.components.select-panel-playground wrapper around the styles to follow the project's CSS layering convention.

Copilot uses AI. Check for mistakes.

9 changes: 4 additions & 5 deletions packages/react/src/experimental/SelectPanel2/SelectPanel.playground.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@ import React from 'react'
import type {Meta, StoryFn} from '@storybook/react-vite'
import type {SelectPanelProps} from './SelectPanel'
import {SelectPanel} from './SelectPanel'
import {ActionList, Box} from '../../index'
import {ActionList} from '../../index'
import data from './mock-story-data'
import {clsx} from 'clsx'
import classes from './SelectPanel.playground.stories.module.css'

export default {
title: 'Deprecated/Components/SelectPanel/Playground',
Expand Down Expand Up @@ -121,10 +123,7 @@ export const Playground: StoryFn = args => {
selected={selectedLabelIds.includes(label.id)}
>
<ActionList.LeadingVisual>
<Box
sx={{width: 14, height: 14, borderRadius: '100%'}}
style={{backgroundColor: `#${label.color}`}}
/>
<div className={clsx(classes.ColorIndicator)} style={{backgroundColor: `#${label.color}`}} />
Copy link
Preview

Copilot AI Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The clsx call is unnecessary here since you're only passing a single class name. You can simplify this to className={classes.ColorIndicator}.

Suggested change
<div className={clsx(classes.ColorIndicator)} style={{backgroundColor: `#${label.color}`}} />
<div className={classes.ColorIndicator} style={{backgroundColor: `#${label.color}`}} />

Copilot uses AI. Check for mistakes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that we don't need clsx here, and so we can probably remove the import as well

</ActionList.LeadingVisual>
{label.name}
<ActionList.Description variant="block">{label.description}</ActionList.Description>
Expand Down
Loading