-
Notifications
You must be signed in to change notification settings - Fork 626
Update SideNav.dev.stories.tsx to no longer use styled-components #6527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Co-authored-by: hectahertz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the SideNav dev stories from using the deprecated Box
component (which relies on styled-components) to CSS modules as part of the broader styled-components migration effort.
- Removed
Box
component dependency and replaced with standarddiv
elements - Added CSS module with equivalent styling using design token CSS custom properties
- Updated the
LightweightVariant
story to use the new CSS classes while maintaining visual appearance
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/react/src/stories/deprecated/SideNav.dev.stories.tsx | Removed Box import, added CSS module import, replaced Box components with div elements using CSS classes |
packages/react/src/stories/deprecated/SideNav.dev.module.css | Added CSS module with ContainerBox and MenuHeader classes using design token CSS custom properties |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
@copilot can you run npm format? |
size-limit report 📦
|
Co-authored-by: hectahertz <[email protected]>
Head branch was pushed to by a user without write access
As part of the migration away from
styled-components
, this PR updatespackages/react/src/stories/deprecated/SideNav.dev.stories.tsx
to use CSS modules instead of the deprecatedBox
component.Changes Made
Box
import: TheBox
component was removed from the imports as it relies on styled-componentsSideNav.dev.module.css
with equivalent styles for the container and menu headerBox
components in theLightweightVariant
story were replaced withdiv
elements using CSS classesCSS Classes Added
.ContainerBox
: Provides border, padding, background, and max-width styling for the outer container.MenuHeader
: Provides border-bottom, margin, and padding styling for the menu header sectionThe visual appearance of the stories remains unchanged while removing the dependency on styled-components infrastructure.
Fixes #6526.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.