Skip to content

Update Hidden.examples.stories.tsx to no longer use styled-components #6531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+23 −10
Open

Update Hidden.examples.stories.tsx to no longer use styled-components #6531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f9b8f28
Initial plan
Copilot Aug 8, 2025
b8ff3a2
Successfully migrate Hidden.examples.stories.tsx away from styled-com…
Copilot Aug 8, 2025
14d8eaf
Merge branch 'main' into copilot/fix-6530
hectahertz Aug 22, 2025
fa772c1
test(vrt): update snapshots
hectahertz Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...s-snapshots/IconButton-Keybinding-Hint-on-Description-dark-tritanopia-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../SelectPanel.test.ts-snapshots/SelectPanel-Default-forced-colors-dark-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 12 additions & 0 deletions packages/react/src/Hidden/Hidden.examples.stories.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
.Container {
padding: var(--base-size-16);
}

.DescriptionText {
font-size: var(--text-body-size-small);
color: var(--fgColor-muted);
}

.BoldLink {
font-weight: var(--base-text-weight-semibold);
}
21 changes: 11 additions & 10 deletions packages/react/src/Hidden/Hidden.examples.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import type {Meta} from '@storybook/react-vite'
import {Button, Link, Text, StateLabel, BranchName, Box} from '..'
import {Button, Link, StateLabel, BranchName} from '..'
import {ArrowRightIcon} from '@primer/octicons-react'

import {PageHeader} from '../PageHeader'
import {Hidden} from '.'
import classes from './Hidden.examples.stories.module.css'

export default {
title: 'Experimental/Components/Hidden/Examples',
Expand All @@ -20,7 +21,7 @@ const setViewportParamToNarrow = {
},
}
export const Webhooks = () => (
<Box sx={{padding: 3}}>
<div className={classes.Container}>
<PageHeader role="banner" aria-label="Webhooks">
<PageHeader.ContextArea>
<PageHeader.ParentLink href="http://github.com">Repository settings</PageHeader.ParentLink>
Expand All @@ -39,7 +40,7 @@ export const Webhooks = () => (
</PageHeader.Actions>
</PageHeader.TitleArea>
</PageHeader>
</Box>
</div>
)

export const WebhooksOnNarrowViewport = () => {
Expand All @@ -49,7 +50,7 @@ export const WebhooksOnNarrowViewport = () => {
WebhooksOnNarrowViewport.parameters = setViewportParamToNarrow

export const PullRequestPage = () => (
<Box sx={{padding: 3}}>
<div className={classes.Container}>
<PageHeader role="banner" aria-label="Add Hidden utility component">
<PageHeader.ContextArea>
<PageHeader.ParentLink href="http://github.com">Pull requests</PageHeader.ParentLink>
Expand All @@ -60,8 +61,8 @@ export const PullRequestPage = () => (
<PageHeader.Description>
<StateLabel status="pullOpened">Open</StateLabel>
<Hidden when={['narrow']}>
<Text sx={{fontSize: 1, color: 'fg.muted'}}>
<Link href="#" muted sx={{fontWeight: 'bold'}}>
<span className={classes.DescriptionText}>
<Link href="#" muted className={classes.BoldLink}>
broccolinisoup
</Link>{' '}
wants to merge 3 commits into
Expand All @@ -72,18 +73,18 @@ export const PullRequestPage = () => (
<BranchName href="#" style={{textDecoration: 'underline'}}>
broccolinisoup/add-hidden-component
</BranchName>
</Text>
</span>
</Hidden>
<Hidden when={['regular', 'wide']}>
<Text sx={{fontSize: 1, color: 'fg.muted'}}>
<span className={classes.DescriptionText}>
<BranchName href="#">main</BranchName>
<ArrowRightIcon />
<BranchName href="#">page-header-initial</BranchName>
</Text>
</span>
</Hidden>
</PageHeader.Description>
</PageHeader>
</Box>
</div>
)

export const PullRequestPageOnNarrowViewport = () => {
Expand Down
Loading