Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Aug 11, 2025

This PR removes the usage of the deprecated Box component and sx prop from the KeybindingHint features stories, replacing them with CSS Modules as part of our migration away from styled-components.

Changes made:

  • Replaced Box usage: Removed the Box import and replaced Box elements with simple div elements
  • Created CSS Module: Added KeybindingHint.features.stories.module.css with wrapper classes for the OnEmphasis and OnPrimary stories
  • Maintained visual consistency: Used CSS variables (var(--bgColor-black), var(--button-primary-bgColor-rest), var(--base-size-16)) to preserve the exact same styling

Before:

<Box sx={{backgroundColor: 'var(--bgColor-black)', p: 3}}>
  <KeybindingHint {...args} />
</Box>

After:

<div className={styles.OnEmphasisWrapper}>
  <KeybindingHint {...args} />
</div>

The CSS Module approach provides better performance and aligns with our architectural direction while maintaining identical visual appearance and behavior.

Storybook screenshot showing KeybindingHint features

Fixes #6571.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copy link

changeset-bot bot commented Aug 11, 2025

⚠️ No Changeset found

Latest commit: 04499ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Copilot Copilot AI changed the title [WIP] Update KeybindingHint.features.stories.tsx to no longer use styled-components Update KeybindingHint.features.stories.tsx to no longer use styled-components Aug 11, 2025
@Copilot Copilot AI requested a review from hectahertz August 11, 2025 17:02
Copilot finished work on behalf of hectahertz August 11, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update KeybindingHint.features.stories.tsx to no longer use styled-components
2 participants