Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 14, 2026

Addresses missing test coverage for the SkeletonBox component's custom numeric delay feature. The component supports delay={number} to specify custom delay durations, but tests only covered boolean values.

Changelog

New

  • Added test case validating custom numeric delay behavior (e.g., delay={500})

Changed

N/A

Removed

N/A

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; test-only change, no API modifications

Testing & Reviewing

New test validates:

  • Component doesn't render immediately with custom delay
  • Component remains hidden before delay elapses
  • Component renders after custom delay duration

Run tests: npm test -- SkeletonBox.test.tsx

Merge checklist


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2026

⚠️ No Changeset found

Latest commit: 5d8934f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI changed the title [WIP] WIP address feedback on customizable delay for SkeletonBox feature Add test coverage for custom numeric delay values in SkeletonBox Jan 14, 2026
Copilot AI requested a review from francinelucca January 14, 2026 05:08
@francinelucca francinelucca added the skip changeset This change does not need a changelog label Jan 15, 2026
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 15, 2026
@francinelucca francinelucca marked this pull request as ready for review January 15, 2026 03:33
@francinelucca francinelucca requested a review from a team as a code owner January 15, 2026 03:33
@francinelucca francinelucca merged commit 9c48216 into feat/add-delay-to-skeletonbox Jan 15, 2026
45 of 46 checks passed
@francinelucca francinelucca deleted the copilot/sub-pr-7448 branch January 15, 2026 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants