-
Notifications
You must be signed in to change notification settings - Fork 649
Revert "Change actionlist item inline description styling" #7470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Change actionlist item inline description styling" #7470
Conversation
This reverts commit 4bb6620.
|
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
|
Uh oh! @jonrohan, at least one image you shared is missing helpful alt text. Check your pull request body to fix the following violations:
Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request reverts PR #7427, which had changed the styling of ActionList items with inline descriptions. The original PR attempted to fix overflow issues by changing the layout from flexbox (flex-direction: row) to block display, but this revert restores the original flexbox-based approach.
Changes:
- Reverts CSS styling changes for inline ActionList item descriptions back to using flexbox layout
- Updates visual regression test snapshots to reflect the reverted styling
- Removes the changeset file that documented the original change
Reviewed changes
Copilot reviewed 2 out of 11 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react/src/ActionList/ActionList.module.css | Reverts inline description styling from display: block back to flex-direction: row with align-items: baseline and appropriate gap |
| .playwright/snapshots/.../ActionList-All-combinations-dark-linux.png | Updates visual regression test snapshot for dark theme to match reverted styling |
| .playwright/snapshots/.../ActionList-All-combinations-dark-dimmed-linux.png | Updates visual regression test snapshot for dark-dimmed theme to match reverted styling |
| .changeset/deep-impalas-wave.md | Removes the changeset file that documented the original change being reverted |
Reverts #7427
We found some alignment issues in github-ui