Skip to content

Conversation

@jonrohan
Copy link
Member

@jonrohan jonrohan commented Jan 23, 2026

Reverts #7427

We found some alignment issues in github-ui

CleanShot 2026-01-22 at 16 43 38@2x

@jonrohan jonrohan requested review from a team as code owners January 23, 2026 00:42
@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2026

⚠️ No Changeset found

Latest commit: 6dbb278

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Jan 23, 2026
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 23, 2026
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

@github-actions
Copy link
Contributor

Uh oh! @jonrohan, at least one image you shared is missing helpful alt text. Check your pull request body to fix the following violations:

  • Images should have meaningful alternative text (alt text) at line 5

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request reverts PR #7427, which had changed the styling of ActionList items with inline descriptions. The original PR attempted to fix overflow issues by changing the layout from flexbox (flex-direction: row) to block display, but this revert restores the original flexbox-based approach.

Changes:

  • Reverts CSS styling changes for inline ActionList item descriptions back to using flexbox layout
  • Updates visual regression test snapshots to reflect the reverted styling
  • Removes the changeset file that documented the original change

Reviewed changes

Copilot reviewed 2 out of 11 changed files in this pull request and generated no comments.

File Description
packages/react/src/ActionList/ActionList.module.css Reverts inline description styling from display: block back to flex-direction: row with align-items: baseline and appropriate gap
.playwright/snapshots/.../ActionList-All-combinations-dark-linux.png Updates visual regression test snapshot for dark theme to match reverted styling
.playwright/snapshots/.../ActionList-All-combinations-dark-dimmed-linux.png Updates visual regression test snapshot for dark-dimmed theme to match reverted styling
.changeset/deep-impalas-wave.md Removes the changeset file that documented the original change being reverted

@liuliu-dev liuliu-dev enabled auto-merge January 23, 2026 00:57
@liuliu-dev liuliu-dev added the integration-tests: skipped manually Changes in this PR do not require an integration test label Jan 23, 2026
@liuliu-dev liuliu-dev disabled auto-merge January 23, 2026 00:58
@liuliu-dev liuliu-dev merged commit 3c382a2 into main Jan 23, 2026
67 checks passed
@liuliu-dev liuliu-dev deleted the revert-7427-clara/actionlist-item-inline-description-overflow branch January 23, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: skipped manually Changes in this PR do not require an integration test staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants