Skip to content

Ld warnings #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ldesnogu wants to merge 147 commits into
base: main
Choose a base branch
from
Open

Ld warnings #34

ldesnogu wants to merge 147 commits into from

Conversation

@ldesnogu
Copy link
Collaborator

@ldesnogu ldesnogu commented Jul 28, 2024

Check build.

@tdulcet tdulcet changed the base branch from main to warnings August 1, 2024 11:43
@tdulcet tdulcet self-requested a review August 2, 2024 10:25
Base automatically changed from warnings to main August 3, 2024 16:24
@ldesnogu ldesnogu changed the base branch from main to singlethread August 4, 2024 16:20
@ldesnogu ldesnogu changed the base branch from singlethread to main August 11, 2024 23:12
@ldesnogu ldesnogu force-pushed the ld-warnings branch 5 times, most recently from 0e642ce to e18ebad Compare August 18, 2024 08:00
@ldesnogu ldesnogu force-pushed the ld-warnings branch 2 times, most recently from 1d5b98b to b1e8c41 Compare August 21, 2024 21:20
@ldesnogu ldesnogu force-pushed the ld-warnings branch 15 times, most recently from 4dd71f5 to 7c49e4d Compare September 7, 2024 18:43
ldesnogu added 25 commits August 17, 2025 14:24
@ldesnogu
Rename global cstr variable to g_cstr.
a62e487
@ldesnogu
Rename parameter cstr to p_cstr.
e5d2675
@ldesnogu
Rename in_line to g_in_line for global and p_in_line for parameter.
a70ffb8
@ldesnogu
Remove warning due to using strncpy.
3d46403
@ldesnogu
Fix singlethread compilation of factor.c.
4fd24cd 
Untested. This applies only to AVX512 builds.
@ldesnogu
Remove warnings from factor_test.h.
36c39c5
@ldesnogu
Remove warnings from factor.c.
2f6536d
@ldesnogu
Remove format warnings from Mlucas.c.
f28e202
@ldesnogu
Make mi64_div_y32 source array const.
3a965da
@ldesnogu
Remove copy warnings from factor.c.
708a8ef
@ldesnogu
Fix warnings found on Windows in util.c.
24f651a
@ldesnogu
Fix warnings about not initialized bjmodn/cy variables in radix16_dit…
f4eebd5 
…N_cy_dif1.c.

These warnings were emitted for singlethread non-SIMD builds.
They are spurious and Ernst already made init at declaration for
multithread builds.
@ldesnogu
Remove warnings from radix12_ditN_cy_dif1.c.
6d42439
@ldesnogu
Remove warnings from radix24_ditN_cy_dif1.c.
9186a16
@ldesnogu
Remove warnings from radix20_ditN_cy_dif1.c.
e2e0b75
@ldesnogu
Remove warnings from radix160_ditN_cy_dif1.c.
bb6fe82
@ldesnogu
Remove warnings from radix224_ditN_cy_dif1.c.
cd5594c
@ldesnogu
Remove warnings from radix192_ditN_cy_dif1.c.
3721386
@ldesnogu
Remove warnings from radix320_ditN_cy_dif1.c.
aa9d01c
@ldesnogu
Remove warnings from radix240_ditN_cy_dif1.c.
e213797
@ldesnogu
Remove warnings from radix288_ditN_cy_dif1.c.
d204aa3
@ldesnogu
Remove warnings from radix352_ditN_cy_dif1.c.
eff1d28
@ldesnogu
Remove warnings from radix384_ditN_cy_dif1.c.
ea9fb86
@ldesnogu
Remove warnings from radix1024_ditN_cy_dif1.c.
2ba3bf5
@ldesnogu
Remove warnings from radix992_ditN_cy_dif1.c.
cbd20c9
This was referenced Nov 5, 2025
Open
Open
@tdulcet tdulcet force-pushed the main branch 2 times, most recently from 07df4ce to 53cf9dc Compare November 20, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdulcet tdulcet tdulcet left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

help wanted Extra attention is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ldesnogu @tdulcet