Conversation
aloknerurkar
reviewed
Aug 4, 2025
aloknerurkar
approved these changes
Aug 4, 2025
shaspitz
added a commit
that referenced
this pull request
Aug 7, 2025
shaspitz
added a commit
that referenced
this pull request
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of our consensus layer is exhibiting odd behavior where recently built block timestamps will jump up to 20 minutes ahead of system time. This PR streamlines implementation, removes unnecessary variables, and makes the logic easier to comprehend/debug. After testing, these changes have fixed the issue.
bb.lastBlockTimevariable was being set independently frombb.executionHead.BlockTime. We now use existingbb.executionHead.BlockTimein-placeheadvariable local toGetPayloadwas being set independently frombb.executionHead. We now use existingbb.executionHeadin-placeloadExecutionHeadwas removed. We now just setbb.executionHeadonce upon service restart insetExecutionHeadFromRPCand subsequently updatebb.executionHeadat the end of everyFinalizeBlockbb.buildDelayMsremoved,bb.buildDelayremains