-
Notifications
You must be signed in to change notification settings - Fork 1
Make generated output files optional #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +0,0 @@ | ||
| -- ** Database generated with pgModeler (PostgreSQL Database Modeler). | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The file still exists but its empty because there are no diffs. |
||
| -- ** pgModeler version: 1.2.2 | ||
| -- ** PostgreSQL version: 18.0 | ||
| -- ** Project Site: pgmodeler.io | ||
| -- ** Model Author: --- | ||
|
|
||
| SET search_path TO pg_catalog,public; | ||
| -- ddl-end -- | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,3 +3,6 @@ db_name: bar | |
| roles: | ||
| - name: alice | ||
| - name: bob | ||
| output: | ||
| sql: {} | ||
| svg: {} | ||
|
Comment on lines
+7
to
+8
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For the example it would be nice to have one with an explicit path.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought about that, but the example is generated via trek init which doesn't have env vars to set these.. I don't think adding env vars there makes sense. I think instead we should improve documentation in general. And/or maybe the example dir shouldn't be generated?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah maybe get rid of the example, since it's empty anyway it doesn't have that much value and it isn't even useful as a starting point, since we have
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lets pick that up in a separate story/PR; to improve docs in general. |
||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -2,3 +2,6 @@ model_name: {{.model_name}} | |||||||||
| db_name: {{.db_name}} | ||||||||||
| roles:{{range .roleNames}} | ||||||||||
| - name: {{.}}{{end}} | ||||||||||
| output: | ||||||||||
| sql: {} | ||||||||||
| svg: {} | ||||||||||
|
||||||||||
| svg: {} | |
| svg: {} | |
| # Note: PNG output can also be configured here if needed, for example: | |
| # png: {} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +0,0 @@ | ||
| -- ** Database generated with pgModeler (PostgreSQL Database Modeler). | ||
| -- ** pgModeler version: 1.2.2 | ||
| -- ** PostgreSQL version: 18.0 | ||
| -- ** Project Site: pgmodeler.io | ||
| -- ** Model Author: --- | ||
|
|
||
| SET search_path TO pg_catalog,public; | ||
| -- ddl-end -- | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not copy the file without read/write?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How? There is no
os.Copyright?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
io.Copy, but I guess in doesn't really matter given the amount of data we're handling here.