Refactor: optimize tools setup using a shared pnpm cache#15
Merged
Conversation
Replaces repetitive dependency installations with a shared `node-tools` image and PNPM cache for efficiency. Updates Dockerfile, compose files, and workflows to streamline dependency management. Removes redundant install steps and simplifies Makefile targets.
b04c612 to
c17327d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces repetitive dependency installations with a reusable
node-toolsimage that includes pre-installed dependencies and leverages PNPM caching for consistent and efficient dependency management. Updates theDockerfile.tools,docker-compose.tools.yaml, Makefile targets, and CI workflows to streamline the build, linting, testing, and type-checking processes. Removes redundantinstall-node-depssteps and optimizes volume usage for caching (node_modulesandpnpm-store).This change reduces redundancy, improves execution speed, and ensures a more consistent development and CI/CD workflow across the project.
Type of Change
How Has This Been Tested?
docker-composeworkflows includinglint,typecheck, andtestto ensure they work correctly with the newnode-toolsimage.lint,test,tsc, etc.) to confirm proper functionality.pnpm-storeandnode_modulesacross runs to ensure dependencies are not redundantly reinstalled.Checklist
Related Issues
None
Screenshots (if applicable)
Additional Context
node-toolsDocker image, shared across alldocker-composeservices to standardize dependency management and eliminate redundant installation steps.install-node-depscalls and directly running tasks using thenode-toolsimage.pnpm-storeandnode_modulesvolumes for faster rebuilds and avoids redundant dependency installations.