-
-
Notifications
You must be signed in to change notification settings - Fork 248
[DRAFT] OPENAI Multiple tool call optimization with structured output support #655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
SolStis86
wants to merge
11
commits into
prism-php:main
Choose a base branch
from
SolStis86:feature-allow-text-provider-option-in-text-request
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[DRAFT] OPENAI Multiple tool call optimization with structured output support #655
SolStis86
wants to merge
11
commits into
prism-php:main
from
SolStis86:feature-allow-text-provider-option-in-text-request
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…configurable parallel tool calls and optional toolChoice finalization
…ng handling in ToolCallMap to resolve the latest reasoning item - Renamed `$reasonings` to `$reasoningItems` for clarity. - Added `resolveReasoningItem` method to determine the most recent reasoning item (ID and summary). - Updated `map` logic to utilize resolved reasoning instead of indexing directly.
…Step logic and support for dynamic parallel tool calls configuration - Introduced `finalRequestStep` method to calculate the final step in requests. - Updated `tool_choice` mapping to consider final request step logic. - Enabled `parallel_tool_calls` configuration to support dynamic values from the request.
… mapping in OpenAI Text handler - Simplified `ToolCallMap` usage by directly inlining the mapping logic during `AssistantMessage` creation. - Removed redundant debug logging for tool calls.
…equest # Conflicts: # src/Providers/OpenAI/Handlers/Text.php
…ToolCalls` property and related method from `Text\Request` - Eliminated unused `parallelToolCalls` property and its associated getter method. - Simplified constructor by removing the redundant property declaration.
Contributor
|
@SolStis86 Anything i can do to help get this completed? also running into this issue Edit: I tried this locally and can confirm it fixed the error for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OPENAI Handler Optimization For Tool Calling
This is just a drafting conceptual PR that enables tool calls with structured output via the Text handler.
Like I say - this is just drafting and requires tests writing etc but am using it locally and it works great