-
Notifications
You must be signed in to change notification settings - Fork 870
DC-5694 OAuth Clarification #7205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Dangerous URL checkNo absolute URLs to prisma.io/docs found. |
Redirect checkThis PR probably requires the following redirects to be added to static/_redirects:
|
WalkthroughReplaces the Management API's single Bearer-token auth with two methods: Service tokens (UI creation, header usage) and OAuth 2.0 (authorization code flow, token exchange). Updates curl/Postman/Swagger examples, replaces the iframe playground with a commented/alternating playground block, updates an internal anchor, and adjusts lychee workflow cache/retry/exclude settings. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Comment |
🍈 Lychee Link Check Report
📊 Results Overview
|
Deploying docs with
|
| Latest commit: |
93f1251
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cff863d4.docs-51g.pages.dev |
| Branch Preview URL: | https://dc-5694-oauth-clarification.docs-51g.pages.dev |
🍈 Lychee Link Check Report
📊 Results Overview
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
content/800-guides/330-management-api-basic.mdx (1)
1-200: Consider adding an OAuth 2.0 alternative or cross-reference.Since the PR updates authentication docs to clarify OAuth 2.0 as an explicit authentication method alongside service tokens, this "basic" guide currently only demonstrates service token authentication. Consider whether this guide should:
- Mention OAuth 2.0 as an alternative authentication method
- Cross-reference users to the main management API docs for OAuth 2.0 guidance
- Remain service-token-focused as a beginner-friendly starting point
This depends on the intended audience scope for this guide. If this is meant as the simplest entry point, service-tokens-only is reasonable with a note that OAuth 2.0 is available in advanced scenarios.
Please clarify the intended scope: should this guide remain service-token-focused for beginners, or should it acknowledge OAuth 2.0 as an available alternative?
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
content/800-guides/330-management-api-basic.mdx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Check internal links
- GitHub Check: runner / linkspector
- GitHub Check: Cloudflare Pages
🔇 Additional comments (1)
content/800-guides/330-management-api-basic.mdx (1)
15-15: No action required—the anchor reference is valid.The heading
### Service tokensexists on line 44 of the referenced management API documentation file. MDX automatically generates the anchor#service-tokensfrom this heading, so the link reference on line 15 is correct and functional.
🍈 Lychee Link Check Report
📊 Results Overview
Errors per inputErrors in 800-guides/160-tanstack-start.mdx
|
🍈 Lychee Link Check Report
📊 Results Overview
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/lychee.yml (1)
31-31: Reasonable adjustment to support expanded documentation validation.The increased retry count aligns well with the PR's expanded OAuth documentation and restructured content, which likely introduces additional links that benefit from more robust validation. The change is straightforward and introduces negligible timing overhead.
Optional improvement: Consider adding a brief inline comment (e.g.,
# Increased for expanded OAuth docs validation) to document the rationale for future maintainers, especially if this is a non-standard number for your project.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/lychee.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: runner / linkspector
- GitHub Check: Check internal links
🍈 Lychee Link Check Report
📊 Results Overview
|
1 similar comment
🍈 Lychee Link Check Report
📊 Results Overview
|
🍈 Lychee Link Check Report
📊 Results Overview
|
|
@CodeRabbit pause |
🍈 Lychee Link Check Report
📊 Results Overview
|
✅ Actions performedReviews paused. |
🍈 Lychee Link Check Report
📊 Results Overview
Errors per inputErrors in 200-orm/050-overview/500-databases/840-cockroachdb.mdx
|
🍈 Lychee Link Check Report
📊 Results Overview
|
🍈 Lychee Link Check Report
📊 Results Overview
Errors per inputErrors in 100-getting-started/02-setup-prisma/100-start-from-scratch/110-relational-databases/100-connect-your-database-node-cockroachdb.mdx
Errors in 100-getting-started/02-setup-prisma/200-add-to-existing-project/110-relational-databases/100-connect-your-database-typescript-cockroachdb.mdx
|
🍈 Lychee Link Check Report
📊 Results Overview
|
|
@CodeRabbit resume |
✅ Actions performedReviews resumed. |
Summary by CodeRabbit
Documentation
Chores