-
Notifications
You must be signed in to change notification settings - Fork 870
add migrate to v7 guide for accelerate users #7357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Dangerous URL checkNo absolute URLs to prisma.io/docs found. |
Redirect checkThis PR probably requires the following redirects to be added to static/_redirects:
|
WalkthroughDocumentation update adding a new "Prisma Accelerate users upgrading from v6" section to the v7 upgrade guide. Covers CLI configuration, client instantiation patterns with accelerateUrl extension, and migration notes. The section content appears duplicated within the file. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Areas requiring attention:
Possibly related PRs
Pre-merge checks✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🍈 Lychee Link Check Report
📊 Results Overview
Errors per inputErrors in 200-orm/050-overview/500-databases/800-sql-server/020-sql-server-local.mdx
Errors in 200-orm/300-prisma-migrate/200-understanding-prisma-migrate/200-shadow-database.mdx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
content/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/400-upgrading-to-prisma-7.mdx(1 hunks)
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: aidankmcalister
Repo: prisma/docs PR: 7301
File: content/800-guides/410-cloudflare-workers.mdx:87-107
Timestamp: 2025-11-20T21:00:02.587Z
Learning: Do not suggest changes to `prisma.config.ts` files in the prisma/docs repository, as the code examples are intentional for documentation purposes.
Learnt from: ankur-arch
Repo: prisma/docs PR: 7066
File: content/200-orm/200-prisma-client/700-debugging-and-troubleshooting/245-troubleshooting-binary-size-issues.mdx:8-22
Timestamp: 2025-08-11T09:40:55.237Z
Learning: When the queryCompiler preview feature is enabled in Prisma ORM (v6.7.0+), it does not require Rust engines for CLI tools like `prisma migrate` or `prisma db pull`. The previous understanding that CLI tools would still need Rust binaries even with queryCompiler enabled is incorrect.
📚 Learning: 2025-08-11T09:40:55.237Z
Learnt from: ankur-arch
Repo: prisma/docs PR: 7066
File: content/200-orm/200-prisma-client/700-debugging-and-troubleshooting/245-troubleshooting-binary-size-issues.mdx:8-22
Timestamp: 2025-08-11T09:40:55.237Z
Learning: When the queryCompiler preview feature is enabled in Prisma ORM (v6.7.0+), it does not require Rust engines for CLI tools like `prisma migrate` or `prisma db pull`. The previous understanding that CLI tools would still need Rust binaries even with queryCompiler enabled is incorrect.
Applied to files:
content/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/400-upgrading-to-prisma-7.mdx
📚 Learning: 2025-11-20T21:00:02.587Z
Learnt from: aidankmcalister
Repo: prisma/docs PR: 7301
File: content/800-guides/410-cloudflare-workers.mdx:87-107
Timestamp: 2025-11-20T21:00:02.587Z
Learning: Do not suggest changes to `prisma.config.ts` files in the prisma/docs repository, as the code examples are intentional for documentation purposes.
Applied to files:
content/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/400-upgrading-to-prisma-7.mdx
📚 Learning: 2025-10-09T21:32:50.340Z
Learnt from: aidankmcalister
Repo: prisma/docs PR: 7167
File: content/900-ai/prompts/astro.mdx:84-84
Timestamp: 2025-10-09T21:32:50.340Z
Learning: The `npx prisma init` command supports the following flags: `--db` (shorthand for `--datasource-provider prisma+postgres`), `--output` (specifies output location for generated client), `--generator-provider` (defines the generator provider), `--datasource-provider`, `--url`, `--preview-feature`, and `--with-model`. These are documented valid CLI options for Prisma init command.
Applied to files:
content/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/400-upgrading-to-prisma-7.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Check internal links
- GitHub Check: Cloudflare Pages
🔇 Additional comments (5)
content/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/400-upgrading-to-prisma-7.mdx (5)
215-242: Clear and well-structured guidance for Accelerate migration.The section provides practical, step-by-step instructions with appropriate warnings about driver adapter incompatibility. The placement after the general "Driver adapters and client instantiation" section makes logical sense, allowing readers to adapt the general guidance for their Accelerate-specific setup. The fallback guidance on line 241 is a helpful touch for future migrations.
215-242: Verify the section is not duplicated within the PR.The AI-generated summary indicates this section "appears inserted in two places," but the provided code shows only a single instance. Please confirm whether the duplication concern is accurate—if the section does appear twice in the actual PR, one instance should be removed to prevent redundancy.
215-242: Clear, practical guidance with strong pedagogical structure.This section excels at bridging the gap between the general driver adapter pattern and Accelerate-specific setup. The three-step breakdown is easy to follow, the warning on line 216 prevents a critical misconfiguration, and the examples are production-ready. The placement after "Driver adapters and client instantiation" logically guides readers from general concepts to specific context. The note on line 241 about switching away from Accelerate later shows good forward-thinking about user lifecycle.
215-242: No changes needed—the section is not duplicated in the PR. The rg search found only one instance of the section heading "Prisma Accelerate users upgrading from v6" in the file. The AI-generated summary that claimed duplication was inaccurate.
238-239: No changes needed —accelerateUrlis the correct Prisma Client v7 API.The code correctly uses
accelerateUrlin the PrismaClient constructor with.$extends(withAccelerate()). This is the documented pattern for Prisma 7. TheDATABASE_URLenvironment variable is appropriate here when it contains aprisma://Accelerate connection string.
...ent/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/400-upgrading-to-prisma-7.mdx
Show resolved
Hide resolved
🍈 Lychee Link Check Report
📊 Results Overview
Errors per inputErrors in 200-orm/050-overview/100-introduction/250-should-you-use-prisma.mdx
|
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.