-
Notifications
You must be signed in to change notification settings - Fork 870
docs: document removal of --skip-generate and --skip-seed flags in Prisma 7 #7385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: document removal of --skip-generate and --skip-seed flags in Prisma 7 #7385
Conversation
WalkthroughDocumentation updated to remove Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related issues
Possibly related PRs
Pre-merge checks✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dangerous URL checkNo absolute URLs to prisma.io/docs found. |
Redirect checkThis PR probably requires the following redirects to be added to static/_redirects:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
content/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/400-upgrading-to-prisma-7.mdx (1)
378-383: Tighten command naming + make the “what to run now” steps explicitConsider:
- Using the fully-qualified commands consistently (
prisma migrate dev,prisma db push) instead of “migrate dev/db push” (reduces ambiguity for skimmers).- Adding the explicit follow-up commands inline (e.g., “Run
npx prisma generate” and (for seeding) “Runnpx prisma db seed”), ideally with links to thegenerate/ seeding docs.content/200-orm/500-reference/200-prisma-cli-reference.mdx (1)
1202-1207: Make the replacement action unambiguous (show the exact command)Minor clarity tweak: instead of “Run it explicitly if needed”, consider spelling out the command users should run (e.g., “Run
prisma generateexplicitly if you need updated Prisma Client artifacts afterdb push.”).
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
content/200-orm/500-reference/200-prisma-cli-reference.mdx(2 hunks)content/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/400-upgrading-to-prisma-7.mdx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Check internal links
- GitHub Check: Cloudflare Pages
Deploying docs with
|
| Latest commit: |
3ef821f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://43b36bb8.docs-51g.pages.dev |
| Branch Preview URL: | https://dr-6471-db-push-skip-generat.docs-51g.pages.dev |
1924b90
🍈 Lychee Link Check Report
📊 Results Overview
Errors per inputErrors in 800-guides/380-vercel-app-deployment.mdx
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
content/200-orm/500-reference/200-prisma-cli-reference.mdx (1)
1446-1454:migrate resetstill documents--skip-generate/--skip-seed, which contradicts “removed in Prisma 7”.If Prisma 7 removed these flags, this section will mislead users and cause immediate CLI errors. Either remove the flags from this table (recommended), or add explicit version-conditional wording and a Prisma 7 warning (consistent with
db push/migrate dev).Proposed diff (remove flags, add Prisma 7 warning consistent with other sections):
#### Options | Option | Required | Description | Default | | :---------------- | :------- | :------------------------------------------------------ | :------ | | `--force` | No | Skip the confirmation prompt | | -| `--skip-generate` | No | Skip triggering generators (for example, Prisma Client) | | -| `--skip-seed` | No | Skip triggering seed | | | `--help` / `--h` | No | Displays the help message | +:::warning + +The `--skip-generate` and `--skip-seed` flags were removed in Prisma 7. If you need Prisma Client artifacts or seed data, run `prisma generate` and your seed command explicitly. + +:::
🧹 Nitpick comments (2)
content/200-orm/500-reference/200-prisma-cli-reference.mdx (2)
1202-1206: Good Prisma 7 callout, but make the “run generate” guidance more actionable (command + when).Consider tweaking the last sentence to include the explicit command and hint at when it’s needed (e.g., after schema changes when Prisma Client is used), so readers don’t wonder what “if needed” means.
1377-1381:migrate devPrisma 7 messaging is a bit duplicated (info + warning).Both blocks convey the same core behavior change (no auto-generate, no auto-seed). I’d keep one (probably the warning) and make it the single source of truth for Prisma 7 behavior to reduce scan fatigue.
Also applies to: 1396-1401
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
content/200-orm/500-reference/200-prisma-cli-reference.mdx(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Check internal links
- GitHub Check: Cloudflare Pages
🍈 Lychee Link Check Report
📊 Results Overview
|
…isma 7
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.