Skip to content

Conversation

@AmanVarshney01
Copy link
Member

@AmanVarshney01 AmanVarshney01 commented Dec 12, 2025

…isma 7

Summary by CodeRabbit

  • Documentation
    • Updated CLI docs to remove the --skip-generate and --skip-seed options and added inline warnings about their removal in Prisma 7.
    • Clarified that db push, migrate dev, migrate diff, and migrate status no longer auto-run Prisma Client generation or seeds; instruct users to run prisma generate and seeds explicitly.
    • Expanded the Prisma 7 upgrade guide with details on removed CLI flags and environment variables.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 12, 2025

Walkthrough

Documentation updated to remove --skip-generate and --skip-seed CLI options across Prisma 7 docs and to add inline Prisma 7 warnings instructing users to run prisma generate and seeds explicitly.

Changes

Cohort / File(s) Summary
Prisma CLI reference updates
content/200-orm/500-reference/200-prisma-cli-reference.mdx
Removed --skip-generate and --skip-seed entries from relevant Options tables; added inline warning/info blocks stating these flags were removed in Prisma 7 and that prisma generate and seeds must be run explicitly.
Prisma 7 upgrade guide
content/200-orm/800-more/.../400-upgrading-to-prisma-7.mdx
Added notes announcing removal of --skip-generate and --skip-seed flags, clarified that migrate dev and db push no longer auto-run client generation or seeds, and expanded the removed environment-variables list with specific PRISMA-related entries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Changes are documentation-only and follow a consistent pattern of removing flags and adding warning blocks.
  • Review focus: verify wording accuracy and consistency across sections, confirm the expanded env-var list matches upstream changes.

Possibly related issues

Possibly related PRs

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the primary change: documenting the removal of two CLI flags (--skip-generate and --skip-seed) in Prisma 7, which is exactly what the changeset implements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

Dangerous URL check

No absolute URLs to prisma.io/docs found.
No local URLs found.

@github-actions
Copy link
Contributor

Redirect check

This PR probably requires the following redirects to be added to static/_redirects:

  • This PR does not change any pages in a way that would require a redirect.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
content/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/400-upgrading-to-prisma-7.mdx (1)

378-383: Tighten command naming + make the “what to run now” steps explicit

Consider:

  • Using the fully-qualified commands consistently (prisma migrate dev, prisma db push) instead of “migrate dev / db push” (reduces ambiguity for skimmers).
  • Adding the explicit follow-up commands inline (e.g., “Run npx prisma generate” and (for seeding) “Run npx prisma db seed”), ideally with links to the generate / seeding docs.
content/200-orm/500-reference/200-prisma-cli-reference.mdx (1)

1202-1207: Make the replacement action unambiguous (show the exact command)

Minor clarity tweak: instead of “Run it explicitly if needed”, consider spelling out the command users should run (e.g., “Run prisma generate explicitly if you need updated Prisma Client artifacts after db push.”).

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 44f03b7 and c3985dd.

📒 Files selected for processing (2)
  • content/200-orm/500-reference/200-prisma-cli-reference.mdx (2 hunks)
  • content/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/400-upgrading-to-prisma-7.mdx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Check internal links
  • GitHub Check: Cloudflare Pages

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 12, 2025

Deploying docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3ef821f
Status: ✅  Deploy successful!
Preview URL: https://43b36bb8.docs-51g.pages.dev
Branch Preview URL: https://dr-6471-db-push-skip-generat.docs-51g.pages.dev

View logs

mhartington
mhartington previously approved these changes Dec 12, 2025
ArthurGamby
ArthurGamby previously approved these changes Dec 12, 2025
@github-actions
Copy link
Contributor

🍈 Lychee Link Check Report

Note: Links are cached for 5 minutes. Failed links (timeouts, rate limits) are retried in a second run with longer timeout.

📊 Results Overview

Status Count
🔍 Total 2293
✅ Successful 2262
⏳ Timeouts 0
🔀 Redirected 4
👻 Excluded 24
❓ Unknown 0
🚫 Errors 2
⛔ Unsupported 1

Errors per input

Errors in 800-guides/380-vercel-app-deployment.mdx

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
content/200-orm/500-reference/200-prisma-cli-reference.mdx (1)

1446-1454: migrate reset still documents --skip-generate / --skip-seed, which contradicts “removed in Prisma 7”.

If Prisma 7 removed these flags, this section will mislead users and cause immediate CLI errors. Either remove the flags from this table (recommended), or add explicit version-conditional wording and a Prisma 7 warning (consistent with db push / migrate dev).

Proposed diff (remove flags, add Prisma 7 warning consistent with other sections):

 #### Options

 | Option            | Required | Description                                             | Default |
 | :---------------- | :------- | :------------------------------------------------------ | :------ |
 | `--force`         | No       | Skip the confirmation prompt                            |         |
-| `--skip-generate` | No       | Skip triggering generators (for example, Prisma Client) |         |
-| `--skip-seed`     | No       | Skip triggering seed                                    |         |
 | `--help` / `--h`  | No       | Displays the help message                               |

+:::warning
+
+The `--skip-generate` and `--skip-seed` flags were removed in Prisma 7. If you need Prisma Client artifacts or seed data, run `prisma generate` and your seed command explicitly.
+
+:::
🧹 Nitpick comments (2)
content/200-orm/500-reference/200-prisma-cli-reference.mdx (2)

1202-1206: Good Prisma 7 callout, but make the “run generate” guidance more actionable (command + when).

Consider tweaking the last sentence to include the explicit command and hint at when it’s needed (e.g., after schema changes when Prisma Client is used), so readers don’t wonder what “if needed” means.


1377-1381: migrate dev Prisma 7 messaging is a bit duplicated (info + warning).

Both blocks convey the same core behavior change (no auto-generate, no auto-seed). I’d keep one (probably the warning) and make it the single source of truth for Prisma 7 behavior to reduce scan fatigue.

Also applies to: 1396-1401

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c3985dd and 1924b90.

📒 Files selected for processing (1)
  • content/200-orm/500-reference/200-prisma-cli-reference.mdx (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Check internal links
  • GitHub Check: Cloudflare Pages

@github-actions
Copy link
Contributor

🍈 Lychee Link Check Report

Note: Links are cached for 5 minutes. Failed links (timeouts, rate limits) are retried in a second run with longer timeout.

📊 Results Overview

Status Count
🔍 Total 2293
✅ Successful 2260
⏳ Timeouts 0
🔀 Redirected 8
👻 Excluded 24
❓ Unknown 0
🚫 Errors 0
⛔ Unsupported 1

@AmanVarshney01 AmanVarshney01 merged commit 980e2ec into main Dec 12, 2025
8 checks passed
@AmanVarshney01 AmanVarshney01 deleted the dr-6471-db-push-skip-generate-flag-is-gone-in-prisma-7 branch December 12, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants