Skip to content

Conversation

@Aijeyomah
Copy link
Contributor

@Aijeyomah Aijeyomah commented Oct 13, 2025

Description

  • Support @ignore directives on values in enums types
  • Update psl/psl/Cargo.toml to enable all psl-core features for the test environment to resolve the unresolved import errors during cargo test -p psl
  • Add test to verify functionality

Note to reviewer

The issue raised included adding support for the @deprecated directive, but that work is out of scope for this pull request. I plan to open a separate PR to handle the @deprecated directive.

Closes #27911

@Aijeyomah
Copy link
Contributor Author

@jacek-prisma @jkomyno, can you help review this PR? Thanks!

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 14, 2025

CodSpeed Performance Report

Merging #5648 will not alter performance

Comparing Aijeyomah:feature/support-enum-ignore-directive (bdaae63) with main (1d6ed60)

Summary

✅ 11 untouched

@Aijeyomah
Copy link
Contributor Author

@aqrln can you help review this PR? Also, I got the authorization error when I tried pushing the integration branch after following the steps(Community PRs: create a local branch for a branch coming from a fork)
to create a local integration branch to test my changes on Prisma repo.

@aqrln aqrln mentioned this pull request Oct 27, 2025
@aqrln
Copy link
Member

aqrln commented Oct 27, 2025

@Aijeyomah

Also, I got the authorization error when I tried pushing the integration branch after following the steps(Community PRs: create a local branch for a branch coming from a fork)

I think this specific section is meant for the maintainers — sorry for the confusion.

I have approved the CI workflow, and I pushed an integration branch: #5659. If the build succeeds, an automated integration PR will be automatically opened on prisma/prisma side in about an hour or so.

Please let me know if/when the integration branch needs to be updated.

I won't have time to review the PR today, I'll have a look tomorrow.

Thank you for contributing so actively!

@aqrln aqrln added this to the 6.19.0 milestone Oct 27, 2025
@Aijeyomah
Copy link
Contributor Author

Aijeyomah commented Oct 28, 2025

@aqrln Thanks for creating the integration branch earlier 5659. After this branch was created and some of the checks were run (not all passed). I couldn't find any helpful resource on how to test the engines on prisma/prisma.

Yesterday, I tried testing the changes by switching to the automated integration branch on locally on Primsa mono-repo and running pnpm install, and also rebuilt the packages and tested, but I couldn't see my changes there, but I can see it works in the prisma-engine code. I think I am missing some crucial steps in testing these changes, and I'd appreciate if you could give me a guide on how to go about it.

@aqrln
Copy link
Member

aqrln commented Oct 28, 2025

@Aijeyomah hmm, it looks like something is wrong with the automation. I triggered an integration release manually now: https://github.com/prisma/prisma-engines/actions/runs/18876278132

@aqrln
Copy link
Member

aqrln commented Oct 28, 2025

@aqrln
Copy link
Member

aqrln commented Oct 28, 2025

Some tests are failing there because your branch is not up-to-date with main. I updated the integration branch (not the original branch in your fork though) and started another build: https://github.com/prisma/prisma-engines/actions/runs/18877914326

@aqrln
Copy link
Member

aqrln commented Oct 28, 2025

@Aijeyomah
Copy link
Contributor Author

p-to-date with main. I updated the integration branch (not the original branch in your fork though) and started another build: https://github.com/prisma/prisma-engines/actions/runs/18877914326

@aqrln I was almost excited until just one test failed. 28405 which cancelled the release to dev/integration npm. I really appreciate your help so far, but can you help look into the test here. Thanks!

@aqrln
Copy link
Member

aqrln commented Oct 28, 2025

@Aijeyomah that's a flaky test, ignore it. It's not related to your changes.

I see there are also some network-related issues on CI in this PR, I can restart the failed jobs after the in progress ones finish.

@aqrln
Copy link
Member

aqrln commented Oct 28, 2025

@Aijeyomah I also just restarted the cancelled release job, not sure why exactly it was cancelled. We have a huge number of CI jobs in progress right now because of the Prisma 7 work, and it looks like GitHub might be killing some of them because we might be running into some limits.

@Aijeyomah
Copy link
Contributor Author

@aqrln I've tested my changes and it works as expected. Thanks for helping out

@Aijeyomah
Copy link
Contributor Author

@aqrln @jacek-prisma I have tested this well on the Prisma monorepo, and it works as expected. Please, can you review? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support @ignore directives on enum types

2 participants