-
Notifications
You must be signed in to change notification settings - Fork 285
feature(psl): Support ignore directives on values in enums #5648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feature(psl): Support ignore directives on values in enums #5648
Conversation
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
|
@jacek-prisma @jkomyno, can you help review this PR? Thanks! |
CodSpeed Performance ReportMerging #5648 will not alter performanceComparing Summary
|
|
@aqrln can you help review this PR? Also, I got the authorization error when I tried pushing the integration branch after following the steps(Community PRs: create a local branch for a branch coming from a fork) |
I think this specific section is meant for the maintainers — sorry for the confusion. I have approved the CI workflow, and I pushed an integration branch: #5659. If the build succeeds, an automated integration PR will be automatically opened on Please let me know if/when the integration branch needs to be updated. I won't have time to review the PR today, I'll have a look tomorrow. Thank you for contributing so actively! |
|
@aqrln Thanks for creating the integration branch earlier 5659. After this branch was created and some of the checks were run (not all passed). I couldn't find any helpful resource on how to test the engines on Yesterday, I tried testing the changes by switching to the automated integration branch on locally on Primsa mono-repo and running |
|
@Aijeyomah hmm, it looks like something is wrong with the automation. I triggered an integration release manually now: https://github.com/prisma/prisma-engines/actions/runs/18876278132 |
|
Some tests are failing there because your branch is not up-to-date with |
@aqrln I was almost excited until just one test failed. 28405 which cancelled the release to dev/integration npm. I really appreciate your help so far, but can you help look into the test here. Thanks! |
|
@Aijeyomah that's a flaky test, ignore it. It's not related to your changes. I see there are also some network-related issues on CI in this PR, I can restart the failed jobs after the in progress ones finish. |
|
@Aijeyomah I also just restarted the cancelled release job, not sure why exactly it was cancelled. We have a huge number of CI jobs in progress right now because of the Prisma 7 work, and it looks like GitHub might be killing some of them because we might be running into some limits. |
|
@aqrln I've tested my changes and it works as expected. Thanks for helping out |
|
@aqrln @jacek-prisma I have tested this well on the Prisma monorepo, and it works as expected. Please, can you review? thanks |
Description
@ignoredirectives on values in enums typespsl/psl/Cargo.tomlto enable allpsl-corefeatures for the test environment to resolve the unresolved import errors duringcargo test -p pslNote to reviewer
The issue raised included adding support for the
@deprecateddirective, but that work is out of scope for this pull request. I plan to open a separate PR to handle the@deprecateddirective.Closes #27911