fix: support concurrent indexes in shadow db replay#5799
Open
zacharyliu wants to merge 1 commit intoprisma:mainfrom
Open
fix: support concurrent indexes in shadow db replay#5799zacharyliu wants to merge 1 commit intoprisma:mainfrom
zacharyliu wants to merge 1 commit intoprisma:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughUpdates the PostgreSQL migration execution path to use Changes
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for multiple
CREATE INDEX CONCURRENTLYstatements in migrations was added in #5767. Shadow DB migration replay still used a separate raw SQL execution path, causing shadow creation to fail if a migration existed with multipleCREATE INDEX CONCURRENTLY:This PR updates the shadow database migration path to use the new migration script logic.
This fixes the issue in prisma/prisma#14456 (comment).
Summary by CodeRabbit
Release Notes