main into opt-v2: PathConfig + Witness Caching + Show Circuit Optimization#59
Merged
0xVikasRushi merged 6 commits intomainfrom Feb 6, 2026
Merged
main into opt-v2: PathConfig + Witness Caching + Show Circuit Optimization#590xVikasRushi merged 6 commits intomainfrom
0xVikasRushi merged 6 commits intomainfrom
Conversation
vplasencia
approved these changes
Feb 5, 2026
Member
vplasencia
left a comment
There was a problem hiding this comment.
Looks great to me! Great work 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR merges
main(containing mobile app migration from PR #58) intoopt-v2, combining three key improvements:1. PathConfig Abstraction (from main)
2. Witness Caching (from opt-v2)
Arc<Mutex<...>>caching to avoid redundant witness generation3. Show Circuit Optimization
Benchmark Results (1920 bytes)
Related Issue(s)
Closes #58 merge into opt-v2
Other information
Show Circuit Stats
Resolved Merge Conflicts
prepare_circuit.rs- Combined PathConfig + witness cachingshow_circuit.rs- Combined PathConfig + witness cachingprover.rs-verify_circuitreturnsVec<Scalar>main.rs- Updated all constructor/function callsChecklist