Open
Conversation
This was referenced May 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to help facilitate the conversation in #41, I've copied the content from @johnwilander's comment. This commit is that comment exactly.
The only other commit provides the diff which I believe clarifies the algorithm.
Specifically:
rsabssa_blindfrom @chris-wood's RSA Blind Signature protocol. This function requiressource_secret_token, so it must be generate in step 3.unlinkable_token_signature(I believe this was just a typo.)rsabssa_finalizefunction is used to generate a valid (but unlinkable) signature forsource_secret_token(generated in step 3.)source_secret_tokenis generated such that it's valid for the click source signature. This shouldn't be possible without the private key held by the click source (it would be equivalent to breaking the signature security.) Additionally, returning the click source signature as is would provide a tracking vector.