Modify BroadcastChannel and SharedWorker method names #37
Open
aamuley wants to merge 3 commits intoprivacycg:mainfrom
Open
Modify BroadcastChannel and SharedWorker method names #37aamuley wants to merge 3 commits intoprivacycg:mainfrom
aamuley wants to merge 3 commits intoprivacycg:mainfrom
Conversation
…p with existing Storage constructor classes
Author
|
FYI this PR is failing CI because of this WebIDL issue when we define We would not want to mark the StorageAccessTypes dictionary as |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #31 (comment) the storage handle's
BroadcastChannel()andSharedWorker()method definitions overlap with the storage object constructor names which is unideal. This updates the spec and explainer to prefercreateBroadcastChannel()andcreateSharedWorker()instead.Preview | Diff