Conversation
Requested by TAG
jyasskin
reviewed
May 29, 2025
johannhof
reviewed
May 29, 2025
Member
johannhof
left a comment
johannhof
left a comment
There was a problem hiding this comment.
For both these examples, I believe the TAG ask was to be more specific about the impact on the end user experience in these examples, so we might want to be a little more creative here in describing that.
Co-authored-by: Martin Thomson <mt@lowentropy.net>
Co-authored-by: Johann Hofmann <johannhof@chromium.org>
Co-authored-by: Johann Hofmann <johannhof@chromium.org>
Co-authored-by: Martin Thomson <mt@lowentropy.net>
jyasskin
reviewed
May 29, 2025
johannhof
approved these changes
May 29, 2025
Member
johannhof
left a comment
johannhof
left a comment
There was a problem hiding this comment.
This LGTM, thanks for putting in the work Ari. Maybe let's wait for a signal from Jeffrey and/or Martin that this helps before merging.
Co-authored-by: Johann Hofmann <johannhof@chromium.org>
Co-authored-by: Johann Hofmann <johannhof@chromium.org>
jyasskin
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by TAG