feat: use minifySync instead of async for oxc-minify#837
Closed
Boshen wants to merge 1 commit intoprivatenumber:masterfrom
Closed
feat: use minifySync instead of async for oxc-minify#837Boshen wants to merge 1 commit intoprivatenumber:masterfrom
minifySync instead of async for oxc-minify#837Boshen wants to merge 1 commit intoprivatenumber:masterfrom
Conversation
Using the sync version because the async version spawns a real thread, which is slow for single threaded js benchmarks. The purpose of this PR is to observe performance difference between the async and sync version, feel free to reject if it does not meet the requirements of this project.
Contributor
Author
|
Need to trigger CI on this PR to see some results. |
Owner
|
Results are here: #839 LMK if you want to move forward with this! |
Contributor
Author
Numbers look good. I'm in favor of merging unless the change does not meet this project's "by default" criteria. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the sync version because the async version spawns a real thread, which is slow for single threaded js benchmarks.
The purpose of this PR is to observe performance difference between the async and sync version, feel free to reject if it does not meet the requirements of this project.