chore(CrossValidationReport): Rename estimator_reports_ to reports_#2033
Draft
auguste-probabl wants to merge 13 commits intoprobabl-ai:mainfrom
Draft
chore(CrossValidationReport): Rename estimator_reports_ to reports_#2033auguste-probabl wants to merge 13 commits intoprobabl-ai:mainfrom
estimator_reports_ to reports_#2033auguste-probabl wants to merge 13 commits intoprobabl-ai:mainfrom
Conversation
The test applies to things that have a `reports_` attribute, but in reality the only things `progress_decorator` applies to are skore.*Report and their associated Accessors.
estimator_reports_ to reports_estimator_reports_ to reports_
Collaborator
Author
|
|
Contributor
estimator_reports_ to reports_estimator_reports_ to reports_
estimator_reports_ to reports_estimator_reports_ to reports_
Collaborator
|
Revert changes from |
Contributor
Collaborator
|
I draft the PR since @glemaitre is not happy with #2032. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Depends on #2032, please review and merge this first.
Supersedes #1838
Closes #1760
Thanks @Muhammad-Rebaal for your first attempt.