Skip to content

chore(CrossValidationReport): Rename estimator_reports_ to reports_#2033

Draft
auguste-probabl wants to merge 13 commits intoprobabl-ai:mainfrom
auguste-probabl:push-uwtykwpmtkrk
Draft

chore(CrossValidationReport): Rename estimator_reports_ to reports_#2033
auguste-probabl wants to merge 13 commits intoprobabl-ai:mainfrom
auguste-probabl:push-uwtykwpmtkrk

Conversation

@auguste-probabl
Copy link
Collaborator

@auguste-probabl auguste-probabl commented Sep 12, 2025

Caution

Depends on #2032, please review and merge this first.


Supersedes #1838

Closes #1760

Thanks @Muhammad-Rebaal for your first attempt.

The test applies to things that have a `reports_` attribute,
but in reality the only things `progress_decorator` applies to are
skore.*Report and their associated Accessors.
@auguste-probabl auguste-probabl changed the title chore(all): Rename estimator_reports_ to reports_ chore(CrossValidationReport): Rename estimator_reports_ to reports_ Sep 12, 2025
@auguste-probabl
Copy link
Collaborator Author

auguste-probabl commented Sep 12, 2025

skore-*-project tests fail because they depend on actually published skore versions (they don't see the changes in this PR); I guess the only thing we can do is to keep skore-*-project changes in a separate PR and wait for the skore changes to be released? This is not ideal.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2025

Documentation preview @ b6eec29

@thomass-dev thomass-dev changed the title chore(CrossValidationReport): Rename estimator_reports_ to reports_ chore(CrossValidationReport)!: Rename estimator_reports_ to reports_ Sep 19, 2025
@thomass-dev thomass-dev changed the title chore(CrossValidationReport)!: Rename estimator_reports_ to reports_ chore(CrossValidationReport): Rename estimator_reports_ to reports_ Sep 19, 2025
@thomass-dev
Copy link
Collaborator

thomass-dev commented Sep 19, 2025

Revert changes from skore-<hub|local>-project to be moved in separate PRs.
Re-add estimator_reports_ as a deprecated property.

@github-actions
Copy link
Contributor

Coverage

Coverage Report for skore/
FileStmtsMissCoverMissing
skore/src/skore
   __init__.py230100% 
   _config.py310100% 
   exceptions.py440%4, 15, 19, 23
skore/src/skore/_sklearn
   __init__.py60100% 
   _base.py1981492%45, 58, 127, 130, 183, 186–187, 189–192, 225, 228–229
   find_ml_task.py610100% 
   types.py27196%28
skore/src/skore/_sklearn/_comparison
   __init__.py70100% 
   feature_importance_accessor.py39294%90, 109
   metrics_accessor.py178398%173, 253, 1215
   report.py1070100% 
   utils.py540100% 
skore/src/skore/_sklearn/_cross_validation
   __init__.py90100% 
   data_accessor.py45393%128, 131, 134
   feature_importance_accessor.py240100% 
   metrics_accessor.py182199%244
   report.py138199%485
skore/src/skore/_sklearn/_estimator
   __init__.py90100% 
   data_accessor.py580100% 
   feature_importance_accessor.py144298%223–224
   metrics_accessor.py356897%200, 202, 209, 300, 369, 373, 388, 423
   report.py167298%448–449
skore/src/skore/_sklearn/_plot
   __init__.py30100% 
   base.py102793%61–62, 200, 224–226, 230
   utils.py770100% 
skore/src/skore/_sklearn/_plot/data
   __init__.py20100% 
   table_report.py185199%706
skore/src/skore/_sklearn/_plot/metrics
   __init__.py60100% 
   confusion_matrix.py70494%92, 100, 122, 230
   feature_importance_display.py672168%88, 121–122, 124, 142–146, 148–155, 158–160, 162
   metrics_summary_display.py80100% 
   precision_recall_curve.py280598%455, 555, 559, 619, 751
   prediction_error.py227597%179, 186, 422, 505, 705
   roc_curve.py292897%385, 508, 513, 614, 619, 623, 692, 832
skore/src/skore/_sklearn/train_test_split
   __init__.py00100% 
   train_test_split.py580100% 
skore/src/skore/_sklearn/train_test_split/warning
   __init__.py80100% 
   high_class_imbalance_too_few_examples_warning.py19194%83
   high_class_imbalance_warning.py200100% 
   random_state_unset_warning.py100100% 
   shuffle_true_warning.py90100% 
   stratify_is_set_warning.py100100% 
   time_based_column_warning.py210100% 
   train_test_split_warning.py30100% 
skore/src/skore/_utils
   __init__.py6266%8, 13
   _accessor.py90396%34, 146, 190
   _environment.py27196%40
   _fixes.py80100% 
   _index.py50100% 
   _logger.py22481%15–17, 19
   _measure_time.py100100% 
   _parallel.py38392%23, 33, 124
   _patch.py13561%21, 23–24, 35, 37
   _progress_bar.py450100% 
   _repr_html.py80100% 
   _show_versions.py380100% 
   _testing.py550100% 
skore/src/skore/project
   __init__.py20100% 
   project.py480100% 
   summary.py740100% 
   widget.py165696%436, 439–441, 525–526
TOTAL399811797% 

Tests Skipped Failures Errors Time
1062 5 💤 0 ❌ 0 🔥 4m 31s ⏱️

@thomass-dev
Copy link
Collaborator

I draft the PR since @glemaitre is not happy with #2032.

@thomass-dev thomass-dev marked this pull request as draft September 19, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

api(skoire): Rename estimator_reports_ in CrossValidationReport

2 participants