MET-35 Getter #19
Merged
MET-35 Getter #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MET-35 Implement dummy `Getter`
Definition of done:
|
Contributor
Author
|
woops, probably should have rebased instead of merging |
mugamma
approved these changes
Nov 25, 2025
horizon-blue
approved these changes
Nov 28, 2025
Contributor
horizon-blue
left a comment
horizon-blue
left a comment
There was a problem hiding this comment.
Looks good. I have to admit that I actually didn't read the unit tests in detail, but if the test passes then I assume that they're good :). Feel free to merge it when you're ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have the dummy
AllGetterthat grabs all FMBs for any ray.