Add Array2D bindings & support conversion to/from numpy arrays #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
MET-14 Copy-free data movement to/from Python
and ideally, we should have something that works for both device & host. One idea to achieve this is to use DLPack which has been widely adopted by ML & scientific computing libraries. |
horizon-blue
force-pushed
the
xiaoyan/array2d-nanobind
branch
from
6050dca to
16e874e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Part of MET-14)
Summary of Changes
Introduce bindings for the
Array2Dclass to facilitate data exchange with numpy arrays. This includes methods for creating an Array2D from a numpy array and converting it back, along with tests to validate functionality and error handling.Since
Array2Dare non-owning views of the underlying buffer, any changes made on the new view will be visible to the original array.Test Plans