Update CI + Pre-Push #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Awesome! CI time has gone down form 4m53s to 2m22s. |
horizon-blue
approved these changes
Nov 17, 2025
Contributor
horizon-blue
left a comment
horizon-blue
left a comment
There was a problem hiding this comment.
Looks great! Thank you for the quick fix :). Feel free to merge this PR whenever you feels ready
| # Run tests (pre-push hook) | ||
| - id: test | ||
| name: Run all tests | ||
| entry: scripts/test-quiet.sh |
Contributor
There was a problem hiding this comment.
Perhaps we can remove the unused script now that we don't use it anymore? ;)
Contributor
Author
There was a problem hiding this comment.
Ahh good point. will remove now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I
pixi reinstall genmetaballsto pre-push before testing, so that all C++/CUDA files are always built before testing (FIXES MET-28)pixi installfrom CI, the regular pixi setup action does this already. (FIXES MET-22)Additionally, I have removed the cache-ing of pixi envs from the CI. The cache includes the cuda toolkit, which is way larger than the runner can store. If you look at previous github actions (below), the memory is too large.