fix: enable readfile liquid tag in workflow args #306
Outdated
This check has been superseded by a newer run.
Annotations
Check warning on line 145 in src/workflow-registry.ts
probelabs / Visor: performance
performance Issue
Recursive workflow imports without depth limit could cause stack overflow or excessive memory usage for deeply nested import chains
Raw output
Add a maximum depth limit to the importInternal method to prevent runaway recursion. Track depth in the visited Set or use a separate depth counter.
Check warning on line 328 in src/utils/worktree-manager.ts
probelabs / Visor: performance
performance Issue
Synchronous git operations in worktree refresh logic could block event loop, especially for large repositories or slow network connections
Raw output
Consider making git operations async or adding timeouts to prevent blocking. The fetchRef and checkout operations could benefit from Promise.race with timeout.
Check notice on line 30 in src/providers/workflow-check-provider.ts
probelabs / Visor: performance
performance Issue
Creating new Liquid instance with createExtendedLiquid() in constructor is efficient, but ensure the instance is reused across multiple executions rather than recreated
Raw output
The current implementation correctly reuses the instance. This is informational - the pattern is correct.
Check notice on line 64 in src/workflow-executor.ts
probelabs / Visor: performance
performance Issue
Creating new Liquid instance with createExtendedLiquid() in constructor is efficient, but ensure the instance is reused across multiple executions rather than recreated
Raw output
The current implementation correctly reuses the instance. This is informational - the pattern is correct.
Check warning on line 544 in src/test-runner/index.ts
probelabs / Visor: performance
performance Issue
Creating new Liquid instance for each output computation in test runner is inefficient for repeated calls
Raw output
Cache the createExtendedLiquid() instance at class level or module level to avoid recreating it for each output computation.
Check warning on line 52 in src/state-machine/dispatch/on-init-handlers.ts
probelabs / Visor: performance
performance Issue
Creating new Liquid instance for each template rendering call in renderTemplateArguments is inefficient
Raw output
Cache the createExtendedLiquid() instance at module level or pass it as a parameter to avoid recreating it for each template rendering.
Check warning on line 53 in src/state-machine/dispatch/template-renderer.ts
probelabs / Visor: performance
performance Issue
Creating new Liquid instance for each template rendering call is inefficient
Raw output
Cache the createExtendedLiquid() instance at module level to avoid recreating it for each template rendering.
Check warning on line 3137 in src/state-machine/states/level-dispatch.ts
probelabs / Visor: performance
performance Issue
Creating new Liquid instance for each template rendering call is inefficient
Raw output
Cache the createExtendedLiquid() instance at module level to avoid recreating it for each template rendering.
Check notice on line 171 in src/slack/socket-runner.ts
probelabs / Visor: performance
performance Issue
Empty catch block after ensureClient() could hide errors and cause performance issues if client initialization fails repeatedly
Raw output
Add logging to the catch block to track client initialization failures. This helps diagnose performance issues from repeated failed attempts.
Check notice on line 544 in src/utils/worktree-manager.ts
probelabs / Visor: performance
performance Issue
Git fetch operation has 60 second timeout which may be too long for slow network conditions, causing delays
Raw output
Consider making the timeout configurable or reducing it for better responsiveness. The current 60s timeout is reasonable for most cases but could be optimized.
Check warning on line 137 in src/workflow-registry.ts
probelabs / Visor: performance
performance Issue
Recursive workflow imports with URL fetching could cause multiple network requests in parallel, potentially overwhelming the network
Raw output
Consider adding request throttling or concurrency limits when importing multiple workflows from URLs.