feat: add new query-forwarding option, refactor code to allow onopen, onerror and onmessage overridable#382
Conversation
Collaborator
Uzlopak
commented
May 30, 2025
Uzlopak
commented
- make query forwarding configurable (was just to write the first test)
- make onopen, onerror and onmessage overridable
- start and stop of the SmeeClient are now async, so we can await them.
Collaborator
Author
|
EventSource from undici is not detecting disconnects, so we can not replace yet eventsource package with undici ones. |
gr2m
approved these changes
May 30, 2025
Contributor
There was a problem hiding this comment.
Changes look good to me.
Given the amount of changes I suggest to release a fix version, just in case a regression is introduced that we missed. It will make it easier to track it down.
Or maybe a feature release, since query-forwarding seems to be a new option?
wolfy1339
reviewed
May 30, 2025
Contributor
wolfy1339
left a comment
wolfy1339
left a comment
There was a problem hiding this comment.
Better to explicitly define return types
Co-authored-by: wolfy1339 <4595477+wolfy1339@users.noreply.github.com>
Collaborator
Author
|
Actually |
wolfy1339
changed the title
query-forwarding option, refactor code to allow onopen, onerror and onmessage overridable
|
🎉 This PR is included in version 4.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.