Removing var keyword from test code (#604)

iRohitSingh · web-flow · commit 3265808691c8 · 2021-04-25T15:34:49.000-04:00
diff --git a/test/tests/p5.Amplitude.js b/test/tests/p5.Amplitude.js
@@ -1,9 +1,9 @@
-var expect = chai.expect;
+const expect = chai.expect;
 
 describe('p5.Amplitude', function () {
   this.timeout(1000);
 
-  var sf, amp, osc, oAmp;
+  let sf, amp, osc, oAmp;
 
   it('can be created', function () {
     amp = new p5.Amplitude();
diff --git a/test/tests/p5.AudioIn.js b/test/tests/p5.AudioIn.js
@@ -1,20 +1,20 @@
-var expect = chai.expect;
+const expect = chai.expect;
 
 describe('p5.AudioIn', function () {
   it('can be created and disposed', function () {
-    var mic = new p5.AudioIn();
+    const mic = new p5.AudioIn();
     mic.dispose();
   });
 
   it('can be started and stopped', function () {
-    var mic = new p5.AudioIn();
+    const mic = new p5.AudioIn();
     mic.start(function () {
       mic.stop();
     });
   });
 
   it('can get sources', function (done) {
-    var mic = new p5.AudioIn();
+    const mic = new p5.AudioIn();
     mic.getSources().then(function (sources) {
       console.log(sources);
       expect(sources).to.be.an('array');
@@ -23,7 +23,7 @@ describe('p5.AudioIn', function () {
   });
 
   it('can set source', function (done) {
-    var mic = new p5.AudioIn();
+    const mic = new p5.AudioIn();
     expect(mic.currentSource).to.be.null;
 
     return mic.getSources().then(function () {
diff --git a/test/tests/p5.AudioVoice.js b/test/tests/p5.AudioVoice.js
@@ -1,6 +1,6 @@
 describe('p5.AudioVoice', function () {
   it('can be created and disposed', function () {
-    var av = new p5.AudioVoice();
+    const av = new p5.AudioVoice();
     av.dispose();
   });
 });
diff --git a/test/tests/p5.Compressor.js b/test/tests/p5.Compressor.js
@@ -1,18 +1,18 @@
-var expect = chai.expect;
+const expect = chai.expect;
 
 describe('p5.Compressor', function () {
   it('can be created and disposed', function () {
-    var compressor = new p5.Compressor();
+    const compressor = new p5.Compressor();
     compressor.dispose();
   });
 
   it('wet dry value can be changed', function () {
-    var compressor = new p5.Compressor();
+    const compressor = new p5.Compressor();
     expect(compressor.drywet(0.5)).to.equal(0.5);
   });
 
   it('can set params', function () {
-    var compressor = new p5.Compressor();
+    const compressor = new p5.Compressor();
     compressor.set(0.5, 20, 15, -50, 0.75);
     expect(compressor.attack()).to.equal(0.5);
     expect(compressor.knee()).to.equal(20);
diff --git a/test/tests/p5.Delay.js b/test/tests/p5.Delay.js
@@ -1,24 +1,24 @@
-var expect = chai.expect;
+const expect = chai.expect;
 
 describe('p5.Delay', function () {
   it('can be created and disposed', function () {
-    var delay = new p5.Delay();
+    const delay = new p5.Delay();
     delay.dispose();
   });
 
   it('has initial feedback value of 0.5', function () {
-    var delay = new p5.Delay();
+    const delay = new p5.Delay();
     expect(delay.feedback()).to.equal(0.5);
   });
 
   it('can set feedback', function () {
-    var delay = new p5.Delay();
+    const delay = new p5.Delay();
     delay.feedback(0.7);
     expect(delay.feedback()).to.be.closeTo(0.7, 0.001);
   });
 
   it('drywet value can be changed', function () {
-    var effect = new p5.Effect();
+    const effect = new p5.Effect();
     expect(effect.drywet(0.5)).to.equal(0.5);
   });
 });
diff --git a/test/tests/p5.Distortion.js b/test/tests/p5.Distortion.js
@@ -1,18 +1,18 @@
-var expect = chai.expect;
+const expect = chai.expect;
 
 describe('p5.Distortion', function () {
   this.timeout(1000);
 
-  var dist = new p5.Distortion();
+  const dist = new p5.Distortion();
 
   it('can be created and disposed', function () {
-    var d = new p5.Distortion();
+    const d = new p5.Distortion();
     d.dispose();
   });
 
   it('can set the amount and oversample', function () {
-    var initialAmt = dist.getAmount();
-    var initialOS = dist.getOversample();
+    const initialAmt = dist.getAmount();
+    const initialOS = dist.getOversample();
     dist.set(1000, '4x');
     expect(dist.getAmount()).not.equal(initialAmt);
     expect(dist.getOversample()).not.equal(initialOS);
diff --git a/test/tests/p5.EQ.js b/test/tests/p5.EQ.js
@@ -1,9 +1,9 @@
-var expect = chai.expect;
+const expect = chai.expect;
 
 describe('p5.EQ', function () {
   it('can be created and disposed', function () {
-    var origSoundArrayLength = p5.soundOut.soundArray.length;
-    var eq = new p5.EQ();
+    const origSoundArrayLength = p5.soundOut.soundArray.length;
+    const eq = new p5.EQ();
     expect(p5.soundOut.soundArray.length).to.not.equal(origSoundArrayLength);
     eq.dispose();
     expect(p5.soundOut.soundArray.length).to.equal(origSoundArrayLength);
@@ -13,7 +13,7 @@ describe('p5.EQ', function () {
   });
 
   it('can be only be created with size 3 or 8', function () {
-    var eq = new p5.EQ();
+    let eq = new p5.EQ();
     expect(eq.bands.length).to.equal(3);
     eq.dispose();
     eq = new p5.EQ(3);
@@ -28,7 +28,7 @@ describe('p5.EQ', function () {
   });
 
   it('a band can be toggled on and off', function () {
-    var eq = new p5.EQ(8);
+    const eq = new p5.EQ(8);
     expect(eq.bands[2].biquad.type).to.equal('peaking');
     eq.bands[2].toggle();
     expect(eq.bands[2].biquad.type).to.equal('allpass');
@@ -37,29 +37,29 @@ describe('p5.EQ', function () {
   });
 
   it('a bands gain value can be changed', function () {
-    var eq = new p5.EQ(8);
+    const eq = new p5.EQ(8);
     expect(eq.bands[2].gain()).to.equal(0);
     eq.bands[2].gain(30);
     expect(eq.bands[2].gain()).to.equal(30);
   });
 
   it('a bands freq value can be changed', function () {
-    var eq = new p5.EQ(8);
+    const eq = new p5.EQ(8);
     expect(eq.bands[0].freq()).to.equal(100);
     eq.bands[0].freq(200);
     expect(eq.bands[0].gain()).to.equal(0);
     expect(eq.bands[0].freq()).to.equal(200);
   });
 
   it('a bands type can be changed', function () {
-    var eq = new p5.EQ();
+    const eq = new p5.EQ();
     expect(eq.bands[2]._untoggledType).to.equal('peaking');
     eq.bands[2].setType('highshelf');
     expect(eq.bands[2]._untoggledType).to.equal('highshelf');
   });
 
   it('drywet value can be changed', function () {
-    var eq = new p5.EQ();
+    const eq = new p5.EQ();
     expect(eq.drywet(0.5)).to.equal(0.5);
   });
 });
diff --git a/test/tests/p5.Effect.js b/test/tests/p5.Effect.js
@@ -1,8 +1,8 @@
-var expect = chai.expect;
+const expect = chai.expect;
 
 describe('p5.Effect', function () {
   it('can be created and disposed', function () {
-    var effect = new p5.Effect();
+    const effect = new p5.Effect();
     effect.dispose();
     expect(effect.wet).to.equal(undefined);
     expect(effect._drywet).to.equal(undefined);
@@ -11,21 +11,21 @@ describe('p5.Effect', function () {
   });
 
   it('drywet value can be changed', function () {
-    var effect = new p5.Effect();
+    const effect = new p5.Effect();
     expect(effect.drywet(0.5)).to.equal(0.5);
   });
 
   it('drywet value can be used as getter and setter', function () {
-    var effect = new p5.Effect();
+    const effect = new p5.Effect();
     expect(effect.drywet(0.5)).to.equal(0.5);
     expect(effect.drywet()).to.equal(0.5);
   });
 
   it('effects can be chained together', function () {
-    var filter = new p5.Filter();
-    var delay = new p5.Delay();
-    var reverb = new p5.Reverb();
-    var distortion = new p5.Distortion();
+    const filter = new p5.Filter();
+    const delay = new p5.Delay();
+    const reverb = new p5.Reverb();
+    const distortion = new p5.Distortion();
     filter.chain(delay, reverb, distortion);
   });
 
diff --git a/test/tests/p5.FFT.js b/test/tests/p5.FFT.js
@@ -1,7 +1,7 @@
-var expect = chai.expect;
+const expect = chai.expect;
 
 describe('p5.FFT', function () {
-  var fft;
+  let fft;
 
   beforeEach(function () {
     fft = new p5.FFT();
diff --git a/test/tests/p5.Filter.js b/test/tests/p5.Filter.js
@@ -1,19 +1,19 @@
-var expect = chai.expect;
+const expect = chai.expect;
 
 describe('p5.Filter', function () {
   it('can be created and disposed', function () {
-    var filter = new p5.Filter();
+    const filter = new p5.Filter();
     filter.dispose();
   });
 
   it('has initial drywet value of 0.5', function () {
-    var filter = new p5.Filter();
+    const filter = new p5.Filter();
     expect(filter.drywet(0.5)).to.equal(0.5);
   });
 
   it('audio can be processed', function () {
-    var filter = new p5.Filter();
-    var sound = new p5.SoundFile('./testAudio/drum.mp3');
+    const filter = new p5.Filter();
+    const sound = new p5.SoundFile('./testAudio/drum.mp3');
     filter.process(sound, 500, 5);
   });
 });
diff --git a/test/tests/p5.MonoSynth.js b/test/tests/p5.MonoSynth.js
@@ -1,13 +1,13 @@
-var expect = chai.expect;
+const expect = chai.expect;
 
 describe('p5.MonoSynth', function () {
   it('can be created and disposed', function () {
-    var monoSynth = new p5.MonoSynth();
+    const monoSynth = new p5.MonoSynth();
     monoSynth.dispose();
   });
 
   it('can play a note string', function (done) {
-    var monoSynth = new p5.MonoSynth();
+    const monoSynth = new p5.MonoSynth();
     monoSynth.play('A2');
 
     // wait for scheduled value to complete
diff --git a/test/tests/p5.Oscillator.js b/test/tests/p5.Oscillator.js
@@ -1,17 +1,17 @@
-var expect = chai.expect;
+const expect = chai.expect;
 
 describe('p5.Oscillator', function () {
   this.timeout(1000);
 
-  var osc = new p5.Oscillator();
-  var amp = new p5.Amplitude();
+  const osc = new p5.Oscillator();
+  const amp = new p5.Amplitude();
 
   after(function () {
     osc.dispose();
   });
 
   it('can be created and disposed', function () {
-    var o = new p5.Oscillator();
+    const o = new p5.Oscillator();
     o.dispose();
   });
 
diff --git a/test/tests/p5.PolySynth.js b/test/tests/p5.PolySynth.js
@@ -1,20 +1,20 @@
-var expect = chai.expect;
+const expect = chai.expect;
 
 describe('p5.PolySynth', function () {
-  var audioContext = p5.prototype.getAudioContext();
+  const audioContext = p5.prototype.getAudioContext();
 
   it('can be created and disposed', function () {
-    var polySynth = new p5.PolySynth();
+    const polySynth = new p5.PolySynth();
     polySynth.dispose();
   });
 
   it('keeps track of the number of voicesInUse', function () {
-    var polySynth = new p5.PolySynth();
-    var noteDuration = 0.01;
+    const polySynth = new p5.PolySynth();
+    const noteDuration = 0.01;
 
-    var noteTriggerTime = audioContext.currentTime;
-    var noteActiveTime = noteTriggerTime + noteDuration / 2;
-    var noteDoneTime = noteTriggerTime + noteDuration;
+    const noteTriggerTime = audioContext.currentTime;
+    const noteActiveTime = noteTriggerTime + noteDuration / 2;
+    const noteDoneTime = noteTriggerTime + noteDuration;
 
     expect(polySynth._voicesInUse.getValueAtTime(noteTriggerTime)).to.equal(0);
 
diff --git a/test/tests/p5.Reverb.js b/test/tests/p5.Reverb.js
@@ -1,29 +1,29 @@
-var expect = chai.expect;
+const expect = chai.expect;
 
 describe('p5.Reverb', function () {
   it('can be created and disposed', function () {
-    var reverb = new p5.Reverb();
+    const reverb = new p5.Reverb();
     reverb.dispose();
   });
 
   it('default parmams-> seconds:3, decay: 2, reverse: false', function () {
-    var reverb = new p5.Reverb();
+    const reverb = new p5.Reverb();
 
     expect(reverb._seconds).to.equal(3);
     expect(reverb._decay).to.equal(2);
     expect(reverb._reverse).to.equal(false);
   });
 
   it('can set seconds, decayRate, reverse', function () {
-    var reverb = new p5.Reverb();
+    const reverb = new p5.Reverb();
     reverb.set(5, 6, true);
     expect(reverb._seconds).to.equal(5);
     expect(reverb._decay).to.equal(6);
     expect(reverb._reverse).to.equal(true);
   });
 
   it('drywet value can be changed', function () {
-    var effect = new p5.Effect();
+    const effect = new p5.Effect();
 
     expect(effect.drywet(0.5)).to.equal(0.5);
   });
diff --git a/test/tests/p5.SoundFile.js b/test/tests/p5.SoundFile.js
diff --git a/test/tests/p5.SoundRecorder.js b/test/tests/p5.SoundRecorder.js
