Merge pull request #639 from satyasaibhushan/bug-fixing

Bug fixing

Author: satyasaibhushan

examples/spatial_panning_listener/sketch.js

@@ -84,11 +84,11 @@ function draw() {
 
 
     //Position the sound in 3 dimensions
-    panner3d.position( flock.boids[0].position.x, 
+    panner3d.set( flock.boids[0].position.x, 
                     flock.boids[0].position.y, 
                     flock.boids[0].position.z);
 
-    listener3d.spatializer.setPosition(0,0,cam_z_pos)
+    listener3d.position(0,0,cam_z_pos)
     //listener3d.orientX(cam_y_rot)
     //listener3d.spatializer.orientY(cam_x_rot)
   //  listener3d.spatializer.setOrientation(cam_x_rot,cam_y_rot,0)

src/app.js

@@ -88,8 +88,8 @@ p5.BandPass = BandPass;
 import EQ from './eq';
 p5.EQ = EQ;
 
-import listener3D from './listener3d';
-p5.listener3D = listener3D;
+import Listener3D from './listener3d';
+p5.Listener3D = Listener3D;
 
 import Panner3D from './panner3d';
 p5.Panner3D = Panner3D;

src/looper.js

@@ -387,12 +387,14 @@ class Score {
   constructor() {
     // for all of the arguments
     this.parts = [];
-    this.currentPart = new Array(arguments.length);
+    this.currentPart = 0;
 
     var thisScore = this;
     for (var i in arguments) {
       this.parts[i] = arguments[i];
-      this.parts[i].nextPart = this.parts[i + 1];
+      if (i > 0) {
+        this.parts[i - 1].nextPart = this.parts[i];
+      }
       this.parts[i].onended = function () {
         thisScore.resetPart(i);
         playNextPart(thisScore);

src/polysynth.js

@@ -1,6 +1,6 @@
 import p5sound from './main';
 import TimelineSignal from 'Tone/signal/TimelineSignal.js';
-import { noteToFreq, freqToMidi } from './helpers';
+import { noteToFreq } from './helpers';
 
 /**
  *  An AudioVoice is used as a single voice for sound synthesis.
@@ -274,9 +274,7 @@ class PolySynth {
     else {
       currentVoice = this._oldest;
 
-      oldestNote = freqToMidi(
-        this.audiovoices[this._oldest].oscillator.freq().value
-      );
+      let oldestNote = this.audiovoices[this._oldest].oscillator.freq().value;
       this.noteRelease(oldestNote);
       this._oldest = (this._oldest + 1) % (this.maxVoices - 1);
     }
@@ -389,6 +387,8 @@ class PolySynth {
         this.notes[n].dispose();
         delete this.notes[n];
       }
+      this._newest = 0;
+      this._oldest = 0;
       return;
     }
 
@@ -400,10 +400,7 @@ class PolySynth {
     } else {
       //Find the scheduled change in this._voicesInUse that will be previous to this new note
       //subtract 1 and schedule this value at time 't', when this note will stop playing
-      var previousVal = Math.max(
-        ~~this._voicesInUse.getValueAtTime(t).value,
-        1
-      );
+      var previousVal = Math.max(~~this._voicesInUse.getValueAtTime(t), 1);
       this._voicesInUse.setValueAtTime(previousVal - 1, t);
       //Then update all scheduled values that follow to decrease by 1 but never go below 0
       if (previousVal > 0) {

src/reverb.js

@@ -103,20 +103,7 @@ class Reverb extends Effect {
    */
   process(src, seconds, decayRate, reverse) {
     src.connect(this.input);
-    var rebuild = false;
-    if (seconds) {
-      this._seconds = seconds;
-      rebuild = true;
-    }
-    if (decayRate) {
-      this._decay = decayRate;
-    }
-    if (reverse) {
-      this._reverse = reverse;
-    }
-    if (rebuild) {
-      this._buildImpulse();
-    }
+    this.set(seconds, decayRate, reverse);
   }
 
   /**

src/soundfile.js

@@ -515,11 +515,11 @@ class SoundFile {
    * </code></div>
    */
   playMode(str) {
-    var s = str.toLowerCase();
+    var s = str.toLowerCase().trim();
 
     // if restart, stop all other sounds from playing
     if (s === 'restart' && this.buffer && this.bufferSourceNode) {
-      for (var i = 0; i < this.bufferSourceNodes.length - 1; i++) {
+      for (var i = 0; i < this.bufferSourceNodes.length; i++) {
         var now = p5sound.audiocontext.currentTime;
         this.bufferSourceNodes[i].stop(now);
       }
@@ -715,10 +715,9 @@ class SoundFile {
       this._paused = false;
     } else if (this.buffer && this.bufferSourceNode) {
       var now = p5sound.audiocontext.currentTime;
-      var t = time || 0;
       this.pauseTime = 0;
-      this.bufferSourceNode.stop(now + t);
-      this._counterNode.stop(now + t);
+      this.bufferSourceNode.stop(now + time);
+      this._counterNode.stop(now + time);
       this._playing = false;
       this._paused = false;
     }
@@ -999,7 +998,7 @@ class SoundFile {
    * @return {Number} [channels]
    */
   channels() {
-    return this.buffer.numberOfChannels;
+    if (this.buffer) return this.buffer.numberOfChannels;
   }
 
   /**
@@ -1010,7 +1009,7 @@ class SoundFile {
    * @return {Number} [sampleRate]
    */
   sampleRate() {
-    return this.buffer.sampleRate;
+    if (this.buffer) return this.buffer.sampleRate;
   }
 
   /**
@@ -1022,7 +1021,7 @@ class SoundFile {
    * @return {Number} [sampleCount]
    */
   frames() {
-    return this.buffer.length;
+    if (this.buffer) return this.buffer.length;
   }
 
   /**
@@ -1045,7 +1044,7 @@ class SoundFile {
     if (this.buffer) {
       // set length to window's width if no length is provided
       if (!length) {
-        length = window.width * 5;
+        length = window.innerWidth * 5;
       }
       if (this.buffer) {
         var buffer = this.buffer;

test/tests.js

@@ -14,3 +14,4 @@ import('./tests/p5.SoundRecorder.js');
 import('./tests/p5.SoundFile.js');
 import('./tests/p5.Amplitude.js');
 import('./tests/p5.Oscillator.js');
+import('./tests/p5.Reverb.js');