Skip to content

Convert App to a function component. #2308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 30, 2023
Merged

Convert App to a function component. #2308

merged 5 commits into from
Nov 30, 2023

Conversation

lindapaiste
Copy link
Collaborator

@lindapaiste lindapaiste commented Jul 16, 2023 •
edited
Loading

Changes:

  • Convert App to a function component and replicate the existing logic using React hooks.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@lindapaiste lindapaiste mentioned this pull request Aug 7, 2023
Closed
24 tasks
@raclim raclim added this to the Next Release milestone Oct 18, 2023
PiyushChandra17
PiyushChandra17 approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@PiyushChandra17 PiyushChandra17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely Done

raclim
raclim approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this!

@raclim raclim merged commit f21b847 into processing:develop Nov 30, 2023
@raclim raclim moved this from PRs to Review to Done in PR Review Board May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raclim raclim raclim approved these changes

+1 more reviewer

@PiyushChandra17 PiyushChandra17 PiyushChandra17 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Code Cleanup
Status: Done
PR Review Board
Status: Done

Milestone

PATCH Release for 2.10.1

Development

Successfully merging this pull request may close these issues.

3 participants

@lindapaiste @raclim @PiyushChandra17