Skip to content

Connect ShareModal to Redux. #2328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 29, 2024
Merged

Connect ShareModal to Redux. #2328

merged 5 commits into from
Mar 29, 2024

Conversation

lindapaiste
Copy link
Collaborator

Progress on #824

These changes were also part of #2054, but I think that I did too much in that PR and I will re-submit it in pieces.

Changes:

  • ShareModal takes no props.
  • ShareModal accesses values from Redux via useSelector.
  • IDEView does not pass any props down to ShareModal.
  • Removed propTypes which are no longer needed.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

PiyushChandra17
PiyushChandra17 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@PiyushChandra17 PiyushChandra17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely Done, looks good to me.

lindapaiste and others added 2 commits November 25, 2023 13:10
@lindapaiste
Merge remote-tracking branch 'upstream/develop' into refactor/share-m…
3efa347 
…odal

# Conflicts:
#	client/modules/IDE/pages/IDEView.jsx
#	client/modules/IDE/components/IDEOverlays.jsx
@raclim
Merge branch 'develop' into refactor/share-modal
498f995
raclim
raclim approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just ran this branch and it seems good to me! Thanks so much!!!

@raclim raclim merged commit 1ac9b91 into processing:develop Mar 29, 2024
@raclim raclim added this to the MINOR Release for 2.13.0 milestone Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raclim raclim raclim approved these changes

+1 more reviewer

@PiyushChandra17 PiyushChandra17 PiyushChandra17 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Code Cleanup
Status: Done

Milestone

MINOR Release for 2.13.0

Development

Successfully merging this pull request may close these issues.

3 participants

@lindapaiste @raclim @PiyushChandra17