Skip to content

Conversation

lindapaiste
Copy link
Collaborator

Progress on #521

Changes:

  • Refactor functions which are used by server.routes.js to use async/await syntax:
    • userExists
    • projectExists
    • projectForUserExists
    • collectionForUserExists
  • Rewrite the routes to await the exists check.
  • Create a placeholder sendHtml helper function for easier merging with Generate the 404 page using React on the frontend. #2168

@raclim this will definitely have conflicts with #2168. You can merge them in whatever order and I will fix the conflicts. Basically we want the sendHtml function from the 404 PR and the server.routes.js changes from this PR.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link
Contributor

@PiyushChandra17 PiyushChandra17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely Done

@raclim raclim added this to the MINOR Release for 2.12.0 milestone Jan 19, 2024
@raclim raclim merged commit dfa284b into processing:develop Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants