Skip to content

Conversation

lindapaiste
Copy link
Collaborator

Progress on #2358

Changes:

  • Convert CopyableInput to a function component.
  • Initialize the clipboard instance with a useEffect and a useRef.
  • Set the tooltip classnames based on React state rather than manually adding and removing classes (see Avoid direct modification of HTML #2174 ).

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link
Contributor

@PiyushChandra17 PiyushChandra17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@raclim raclim merged commit 7e069ee into processing:develop Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants