Skip to content

Convert AddToCollectionSketchList to a function component #2364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 25, 2024
Merged

Convert AddToCollectionSketchList to a function component #2364

merged 4 commits into from
Jan 25, 2024

Conversation

lindapaiste
Copy link
Collaborator

Progress on #2358 and #2179

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@lindapaiste lindapaiste mentioned this pull request Aug 7, 2023
Closed
24 tasks
@lindapaiste
Merge remote-tracking branch 'upstream/develop' into refactor/AddToCo…
4fd885d 
…llectionSketchList

# Conflicts:
#	client/modules/IDE/components/AddToCollectionSketchList.jsx
PiyushChandra17
PiyushChandra17 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@PiyushChandra17 PiyushChandra17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed these changes thoroughly, looks good to me! Nicely Done.

@lindapaiste
Merge remote-tracking branch 'upstream/develop' into refactor/AddToCo…
e189ad2 
…llectionSketchList

# Conflicts:
#	client/modules/IDE/components/AddToCollectionSketchList.jsx
#	client/modules/User/components/Collection.jsx
@raclim raclim added this to the MINOR Release for 2.12.0 milestone Jan 19, 2024
raclim
raclim approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

@raclim raclim merged commit 6461a36 into processing:develop Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raclim raclim raclim approved these changes

+1 more reviewer

@PiyushChandra17 PiyushChandra17 PiyushChandra17 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Code Cleanup
Status: Done

Milestone

MINOR Release for 2.12.0

Development

Successfully merging this pull request may close these issues.

3 participants

@lindapaiste @raclim @PiyushChandra17