[WIP] Common Table component (part 2) #2382
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # client/modules/App/components/Overlay.jsx
# Conflicts: # client/modules/User/components/Collection.jsx
# Conflicts: # client/modules/IDE/components/AssetList.jsx # client/modules/IDE/components/CollectionList/CollectionListRow.jsx # client/modules/IDE/components/SketchList.jsx # client/modules/User/components/Collection.jsx # client/styles/components/_sketch-list.scss
|
Hi, @lindapaiste is there anything that I can help in completing the table component. |
4 tasks
|
This PR will be closed due to falling out of date, but noted as reference in the linked issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1442
Merge after #2376 and #2379
Changes:
SketchListandCollectionListwhich allow renaming. This is a little bit tricky as the columns cannot be completely independent, since clicking the "Rename" option in the dropdown column causes changes in the "name" column.I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123